Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web, web-twig, web-react): Deprecate UNSTABLE_ActionLayout #1872

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Feat(web, web-twig, web-react): Deprecate UNSTABLE_ActionLayout #1872

merged 4 commits into from
Jan 29, 2025

Conversation

pavelklibani
Copy link
Contributor

Description

🪦 Deprecation of UNSTABLE_ActionLayout

Additional context

Issue reference

Deprecate UNSTABLE_ActionLayout

@pavelklibani pavelklibani self-assigned this Jan 24, 2025
@github-actions github-actions bot added the feature New feature or request label Jan 24, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 24, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit adc2820
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/679a22bd961f230009c78d90
😎 Deploy Preview https://deploy-preview-1872--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Jan 24, 2025 •
edited
Loading

Coverage Status

coverage: 79.469%. remained the same
when pulling adc2820 on feat/ds-1648-action-layout-deprecation
into cfa2e41 on main.

@netlify Netlify
Copy link

netlify bot commented Jan 24, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit adc2820
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/679a22bdb27eca000841d83f

literat
literat approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pavelklibani pavelklibani merged commit bad4fba into main Jan 29, 2025
32 checks passed
@pavelklibani pavelklibani deleted the feat/ds-1648-action-layout-deprecation branch January 29, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curdaj curdaj curdaj approved these changes

@literat literat literat approved these changes

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna is a code owner

@crishpeen crishpeen Awaiting requested review from crishpeen crishpeen is a code owner

@katerinarehorkova katerinarehorkova Awaiting requested review from katerinarehorkova katerinarehorkova is a code owner

Assignees

@pavelklibani pavelklibani

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavelklibani @coveralls @literat @curdaj