Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-twig]: Re-enable twig development #1871

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

literat
Copy link
Collaborator

@literat literat commented Jan 24, 2025

Description

  • Upgraded Symfony to v6.4
  • Upgrade dev dependencies
  • Fix some cross-dependency problems

Additional context

Works for me. Please, try it and add screenshots of your problems into the comments.

I have started with a clean slate.

  • make pristine
  • make install
  • docker image rm -f ...
  • packages/web-twig
  • make build
  • make start

retry with make encore-build

Issue reference

https://jira.almacareer.tech/browse/DS-1571

@github-actions github-actions bot added the maintenance Changes to the build process or auxilary tools and libraries or other maintenance label Jan 24, 2025
Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit dafae39
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6793c5ba0715440008e3e964

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit dafae39
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6793c5bb243cd600082ced69
😎 Deploy Preview https://deploy-preview-1871--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat literat force-pushed the chore/web-twig-docker branch from 5cc42ed to c047411 Compare January 24, 2025 16:48
@literat literat marked this pull request as ready for review January 24, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Changes to the build process or auxilary tools and libraries or other maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant