Feat(web-react): Introduce Vertical Navigation #DS-1627 #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crishpeen
force-pushed
the
feat/vertical-navigation
branch
from
7184850 to
d34b9f7
Compare
curdaj
force-pushed
the
feat/ds-1627-vertical-navigation-react
branch
from
a1eba7e to
449a000
Compare
curdaj
commented
Jan 24, 2025
There was a problem hiding this comment.
Not sure about placing partial components
literat
reviewed
Jan 24, 2025
| <NavigationAction href="#">Link</NavigationAction> | ||
| </NavigationItem> | ||
| <NavigationItem> | ||
| <Dropdown |
There was a problem hiding this comment.
suggestion (if-minor): What about using UncontrolledDropdown so you will not need to create the state handlers?
curdaj
commented
Jan 24, 2025
There was a problem hiding this comment.
Not sure about placing partial components
literat
reviewed
Jan 24, 2025
packages/web-react/src/components/UNSTABLE_Header/demo/HeaderWithNavigationAndNestedItems.tsx
Outdated
Show resolved
Hide resolved
literat
reviewed
Jan 24, 2025
| <Text elementType="span" size="small" emphasis="semibold" UNSAFE_className="text-primary"> | ||
| My Account | ||
| </Text> | ||
| <Icon name="chevron-up" boxSize={20} UNSAFE_className="accessibility-open" /> |
There was a problem hiding this comment.
question: accessibility-open/closed - are we missing some props for this?
literat
reviewed
Jan 24, 2025
packages/web-react/src/components/Navigation/demo/NavigationHorizontalWithDropdown.tsx
Show resolved
Hide resolved
literat
reviewed
Jan 24, 2025
packages/web-react/src/components/Navigation/demo/NavigationVerticalWithCollapse.tsx
Outdated
Show resolved
Hide resolved
literat
reviewed
Jan 24, 2025
...ts/UNSTABLE_Header/demo/HeaderWithNavigationAndNestedItems/SecondaryHorizontalNavigation.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+40
to
+41
| expect(screen.getByRole('navigation')).toHaveClass('Navigation'); | ||
| expect(screen.getByRole('navigation')).toHaveClass(directionClassName); |
There was a problem hiding this comment.
Suggested change
| expect(screen.getByRole('navigation')).toHaveClass('Navigation'); | |
| expect(screen.getByRole('navigation')).toHaveClass(directionClassName); | |
| const element = screen.getByRole('navigation'); | |
| expect(element).toHaveClass('Navigation'); | |
| expect(element).toHaveClass(directionClassName); |
Comment on lines
34
to
36
| const navigationClass = useClassNamePrefix('Navigation'); | ||
| const navigationActionClass = useClassNamePrefix('NavigationAction'); | ||
| const navigationItemClass = useClassNamePrefix('NavigationItem'); |
There was a problem hiding this comment.
Suggested change
| const navigationClass = useClassNamePrefix('Navigation'); | |
| const navigationActionClass = useClassNamePrefix('NavigationAction'); | |
| const navigationItemClass = useClassNamePrefix('NavigationItem'); | |
| const navigationClass = useClassNamePrefix('Navigation'); | |
| const navigationActionClass = `${navigationClass}Action`; | |
| const navigationItemClass = `${navigationClass}Item`; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference