Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web-react): ReactNode type for labels #DS-1632 #1862

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Feat(web-react): ReactNode type for labels #DS-1632 #1862

merged 2 commits into from
Jan 24, 2025

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Jan 22, 2025 •
edited
Loading

Description

  • changed types so label, helperText and validationText accept ReactNode
  • updated READMEs API tables
  • updated unit tests

Additional context

Issue reference

web-react: Allow ReactNode for labels, validationText and helperText

@pavelklibani pavelklibani self-assigned this Jan 22, 2025
@github-actions github-actions bot added the feature New feature or request label Jan 22, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 22, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit ef9c5bb
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6793a0f8fe1a120008ea1f47
😎 Deploy Preview https://deploy-preview-1862--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 22, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit ef9c5bb
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6793a0f812a71100089c6626
😎 Deploy Preview https://deploy-preview-1862--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavelklibani pavelklibani added the run-visual-tests Runs visual regression testing on this PR label Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12903608647/artifacts/2466394608

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12905865759/artifacts/2467046474

@pavelklibani pavelklibani force-pushed the feat/ds-1632-react-nodes branch from 56d1bff to 9582c46 Compare January 22, 2025 10:13
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12905956243/artifacts/2467090431

@pavelklibani pavelklibani force-pushed the feat/ds-1632-react-nodes branch from 9582c46 to fae8b11 Compare January 22, 2025 10:28
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12906224905/artifacts/2467152183

@pavelklibani pavelklibani force-pushed the feat/ds-1632-react-nodes branch from fae8b11 to 2cc9c50 Compare January 22, 2025 10:40
@coveralls
Copy link

coveralls commented Jan 22, 2025 •
edited
Loading

Coverage Status

coverage: 79.469%. remained the same
when pulling ef9c5bb on feat/ds-1632-react-nodes
into be0c466 on main.

@pavelklibani pavelklibani marked this pull request as ready for review January 22, 2025 11:01
@pavelklibani pavelklibani requested review from literat, curdaj and a team as code owners January 22, 2025 11:01
literat
literat approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for all those refactors of the tests. Good job 👍

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12922565558/artifacts/2472456974

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12922565558/artifacts/2473133806

crishpeen
crishpeen approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe we should update storybook too? I don't know if we need it.

packages/web-react/src/components/Select/__tests__/Select.test.tsx Show resolved Hide resolved
@pavelklibani
Feat(web-react): ReactNode type for labels #DS-1632
986f4b3 
- Change type for labels, helperText, and validationText to ReactNode
@pavelklibani pavelklibani force-pushed the feat/ds-1632-react-nodes branch from 05bef22 to 986f4b3 Compare January 24, 2025 05:09
@pavelklibani pavelklibani merged commit ce0a9dc into main Jan 24, 2025
29 checks passed
@pavelklibani pavelklibani deleted the feat/ds-1632-react-nodes branch January 24, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat approved these changes

@crishpeen crishpeen crishpeen approved these changes

@curdaj curdaj Awaiting requested review from curdaj curdaj is a code owner

@katerinarehorkova katerinarehorkova Awaiting requested review from katerinarehorkova katerinarehorkova is a code owner

Assignees

@pavelklibani pavelklibani

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavelklibani @coveralls @literat @crishpeen