Feat(web): Extend Flex direction by reverse value #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- Deprecate row and column values - Change Flex direction values to horizontal and vertical instead of row and column - Extend Flex direction by horizontalReverse value - All demos updated to use new values and created new with reverse order
- Deprecate row and column values - Change Flex direction values to horizontal and vertical instead of row and column - Extend Flex direction by horizontalReverse value - All demos updated to use new values and created new with reverse order
pavelklibani
force-pushed
the
feat/ds-1607-flex-extended
branch
from
ed0f6c9 to
456cd13
Compare
pavelklibani
requested review from
literat,
curdaj,
a team,
adamkudrna and
crishpeen
as code owners
literat
reviewed
Jan 10, 2025
literat
reviewed
Jan 10, 2025
Can you link or create and link an issue for this, please? |
literat
reviewed
Jan 10, 2025
|
Please, checkout the markdown linting issues and fix them. Thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note
Only
horizontal-reversewas implemented right now.The
vertical-reversewill be implemented in the future #DS-1630.Additional context
The depreciation was due to the straightening of the dictionary values
Issue reference
Extend Flex direction