Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Introduce NavigationItem subcomponent and showcase Header with Navigation and Dropdown #1840

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Jan 8, 2025
@github-actions github-actions bot added the feature New feature or request label Jan 8, 2025
@crishpeen crishpeen mentioned this pull request Jan 8, 2025
@coveralls
Copy link

Coverage Status

coverage: 96.838%. remained the same
when pulling d36c4c0 on feature/header-navigation-dropdown
into 14ebbb7 on feature/unstyled-button.

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 866be97
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6786997f46a4f900084cb0d7
😎 Deploy Preview https://deploy-preview-1840--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 866be97
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6786997f5699560008d51b04
😎 Deploy Preview https://deploy-preview-1840--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@literat
Copy link
Collaborator

literat commented Jan 10, 2025

Screenshot 2025-01-10 at 13 35 41
Screenshot 2025-01-10 at 13 35 33

I think we are missing a focused state. In both cases, the opened dropdown looks unrelated to the trigger. The only state change is the arrow. I think I was expecting also some color/background change when I clicked the trigger and the dropdown opened.

And in the first example, it is maybe even worse. Because I do not know if the user icon is related to the account text and if the dropdown is related to the icon or the text. There is no clue that both are the same component.

@crishpeen crishpeen force-pushed the feature/unstyled-button branch from 14ebbb7 to 906ea88 Compare January 14, 2025 14:43
Base automatically changed from feature/unstyled-button to integration/header January 14, 2025 14:57
@crishpeen crishpeen force-pushed the feature/header-navigation-dropdown branch 2 times, most recently from d88ae9a to 90835f7 Compare January 14, 2025 16:32
@crishpeen crishpeen force-pushed the feature/header-navigation-dropdown branch from 90835f7 to 2accc4b Compare January 14, 2025 16:58
@crishpeen crishpeen force-pushed the feature/header-navigation-dropdown branch from 2accc4b to 866be97 Compare January 14, 2025 17:06
@crishpeen
Copy link
Member Author

Screenshot 2025-01-10 at 13 35 41 Screenshot 2025-01-10 at 13 35 33

I think we are missing a focused state. In both cases, the opened dropdown looks unrelated to the trigger. The only state change is the arrow. I think I was expecting also some color/background change when I clicked the trigger and the dropdown opened.

And in the first example, it is maybe even worse. Because I do not know if the user icon is related to the account text and if the dropdown is related to the icon or the text. There is no clue that both are the same component.

this is done as possible with current components. We do not have a design for anything else. However, if we introduce some kind of styled button for this, the change would be simple (just replace the <button class="button-unstyled" with it.

@crishpeen crishpeen merged commit 7c92423 into integration/header Jan 16, 2025
23 checks passed
@crishpeen crishpeen deleted the feature/header-navigation-dropdown branch January 16, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants