-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Introduce NavigationItem
subcomponent and showcase Header with Navigation and Dropdown
#1840
Feat: Introduce NavigationItem
subcomponent and showcase Header with Navigation and Dropdown
#1840
Conversation
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
packages/web/src/scss/components/Navigation/_NavigationItem.scss
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/UNSTABLE_Header/demo/HeaderWithNavigation.tsx
Show resolved
Hide resolved
I think we are missing a focused state. In both cases, the opened dropdown looks unrelated to the trigger. The only state change is the arrow. I think I was expecting also some color/background change when I clicked the trigger and the dropdown opened. And in the first example, it is maybe even worse. Because I do not know if the user icon is related to the account text and if the dropdown is related to the icon or the text. There is no clue that both are the same component. |
packages/web-react/src/components/Navigation/useNavigationItemStyleProps.ts
Outdated
Show resolved
Hide resolved
14ebbb7
to
906ea88
Compare
d88ae9a
to
90835f7
Compare
90835f7
to
2accc4b
Compare
2accc4b
to
866be97
Compare
this is done as possible with current components. We do not have a design for anything else. However, if we introduce some kind of styled button for this, the change would be simple (just replace the |
Description
Additional context
Issue reference