Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web): Introduce button-unstyled helper #1838

Open
wants to merge 1 commit into
base: feature/dropdown-alignment
Choose a base branch
from
Open

Feat(web): Introduce button-unstyled helper #1838

wants to merge 1 commit into from

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@github-actions github-actions bot added the feature New feature or request label Jan 8, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 8, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 14ebbb7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/677e85b4e4d1340008203a9a
😎 Deploy Preview https://deploy-preview-1838--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 8, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 14ebbb7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/677e85b4b52f830008f6e965

@crishpeen crishpeen force-pushed the feature/dropdown-alignment branch from a43b7c7 to a500b28 Compare January 8, 2025 14:02
@crishpeen crishpeen force-pushed the feature/unstyled-button branch from b6e3892 to 14ebbb7 Compare January 8, 2025 14:03
@coveralls
Copy link

Coverage Status

coverage: 96.838%. remained the same
when pulling 14ebbb7 on feature/unstyled-button
into a500b28 on feature/dropdown-alignment.

literat
literat approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discused personally. I think we will be working more on the Buttons in the future.

adamkudrna
adamkudrna approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkudrna adamkudrna adamkudrna approved these changes

@literat literat literat approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

@curdaj curdaj Awaiting requested review from curdaj curdaj is a code owner

Assignees

@crishpeen crishpeen

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crishpeen @coveralls @literat @adamkudrna