Feat: Introduce alignment to Dropdown component #DS-1411 #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crishpeen
requested review from
literat,
adamkudrna,
pavelklibani,
a team and
curdaj
as code owners
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crishpeen
force-pushed
the
integration/header
branch
from
0005622 to
fc5ceb3
Compare
crishpeen
force-pushed
the
feature/dropdown-alignment
branch
from
6d3becd to
a43b7c7
Compare
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12670287379/artifacts/2401164873 |
crishpeen
force-pushed
the
feature/dropdown-alignment
branch
from
a43b7c7 to
a500b28
Compare
curdaj
approved these changes
Jan 9, 2025
packages/web-react/src/components/Dropdown/__tests__/Dropdown.test.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Dropdown/demo/DropdownAlignment.tsx
Outdated
Show resolved
Hide resolved
adamkudrna
approved these changes
Jan 9, 2025
packages/web-twig/src/Resources/components/Dropdown/Dropdown.twig
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Dropdown/useDropdownStyleProps.ts
Outdated
Show resolved
Hide resolved
literat
reviewed
Jan 10, 2025
|
Are we able to present this feature a little bit better, please? This looks like a bug, IMHO. |
pavelklibani
approved these changes
Jan 14, 2025
crishpeen
force-pushed
the
feature/dropdown-alignment
branch
from
a500b28 to
22e2b02
Compare
crishpeen
force-pushed
the
feature/dropdown-alignment
branch
from
22e2b02 to
4204135
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need this for Dropdown in Header Navigation.
Additional context
Issue reference