Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce text linting of our documentation #1588

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

literat
Copy link
Collaborator

@literat literat commented Aug 22, 2024

Description

Linting text content of our documentation files. Only part of the packages are linted due to the changes.

Additional context

https://github.com/lmc-eu/code-quality-tools/blob/main/packages/textlint-rule-preset-lmc/index.js

Applied rules:

Most changes:

  • e.g. -> for example
  • i.e. -> that is
  • normalization of apostrophes to '
  • if you want to -> to

Issue reference

https://jira.almacareer.tech/browse/DS-1496

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit ac0dcf3
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/678130ae60760a000889299b
😎 Deploy Preview https://deploy-preview-1588--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit ac0dcf3
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/678130ae3d9e560008a7434e

@coveralls
Copy link

coveralls commented Aug 22, 2024

Coverage Status

Changes unknown
when pulling cf6b2ac on style/text-linting
into ** on main**.

@adamkudrna
Copy link
Contributor

Introduce teyxt linting of our documentation

Are we also linting commit messages and PR names? 🙂

@literat literat changed the title Introduce teyxt linting of our documentation Introduce text linting of our documentation Aug 26, 2024
@literat
Copy link
Collaborator Author

literat commented Aug 26, 2024

Introduce teyxt linting of our documentation

Are we also linting commit messages and PR names? 🙂

Maybe we should 😅 -> https://github.com/marketplace/actions/pull-request-linter-action

@literat literat marked this pull request as ready for review September 12, 2024 09:11
@literat literat force-pushed the style/text-linting branch 3 times, most recently from 406df67 to 4b9d601 Compare September 12, 2024 14:34
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is way too much opinionated. At least in this form. I mean, there are some nice touches and things I'd like to see checked, but I cannot give it a ✅ as a whole.

@literat (and everyone here) I jotted down some comments but I feel the discussion needs to be more structured. Can we maybe discuss individual rules first? What do you think is the best approach? (Long topics?)

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
DEPRECATIONS-v2.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@literat literat force-pushed the style/text-linting branch from cf6b2ac to 759cbd2 Compare January 5, 2025 13:48
@literat
Copy link
Collaborator Author

literat commented Jan 5, 2025

@adamkudrna Thanks for the review. Let's tweak it to our desires and needs. I think that the most problematic rule will be the stop-words.

Sources of stop words: https://github.com/sapegin/textlint-rule-stop-words?tab=readme-ov-file#sources

CAn be disabled, rewritten or excluded: https://github.com/sapegin/textlint-rule-stop-words?tab=readme-ov-file#defaultwords-default-true

The simple approach now can be just to disable apostrophe and stop-words and move on and in the meantime, discuss the possibilities and options.

@literat
Copy link
Collaborator Author

literat commented Jan 5, 2025

Just for the note: the apostrophe rule cannot be modified, so we can end up with a mixture of apostrophes. But I think the preference is '.

packages/web/README.md Outdated Show resolved Hide resolved
@literat literat force-pushed the style/text-linting branch from 939c1b6 to 396b20e Compare January 10, 2025 14:26
@literat literat force-pushed the style/text-linting branch from 396b20e to ac0dcf3 Compare January 10, 2025 14:37
@literat literat requested a review from adamkudrna January 10, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants