-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce text linting of our documentation #1588
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
Changes unknown |
Are we also linting commit messages and PR names? 🙂 |
Maybe we should 😅 -> https://github.com/marketplace/actions/pull-request-linter-action |
e3ce182
to
91718a8
Compare
406df67
to
4b9d601
Compare
4b9d601
to
cf6b2ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is way too much opinionated. At least in this form. I mean, there are some nice touches and things I'd like to see checked, but I cannot give it a ✅ as a whole.
@literat (and everyone here) I jotted down some comments but I feel the discussion needs to be more structured. Can we maybe discuss individual rules first? What do you think is the best approach? (Long topics?)
cf6b2ac
to
759cbd2
Compare
@adamkudrna Thanks for the review. Let's tweak it to our desires and needs. I think that the most problematic rule will be the Sources of stop words: https://github.com/sapegin/textlint-rule-stop-words?tab=readme-ov-file#sources CAn be disabled, rewritten or excluded: https://github.com/sapegin/textlint-rule-stop-words?tab=readme-ov-file#defaultwords-default-true The simple approach now can be just to disable |
Just for the note: the |
939c1b6
to
396b20e
Compare
396b20e
to
ac0dcf3
Compare
Description
Linting text content of our documentation files. Only part of the packages are linted due to the changes.
Additional context
https://github.com/lmc-eu/code-quality-tools/blob/main/packages/textlint-rule-preset-lmc/index.js
Applied rules:
Most changes:
e.g.
->for example
i.e.
->that is
'
if you want to
->to
Issue reference
https://jira.almacareer.tech/browse/DS-1496