Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LP0004] Updates based on review manager meeting #84

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

llvm-beanz
Copy link
Contributor

This updates the proposal with changes discussed during the review manager meeting. The changes are:

  • Update references to code owners to reflect the new maintainer role.
  • Clarify that the project council will serve as a catch all for issues not covered by an area team.
  • Explicitly state that area teams must communicate a timeline for decision making.
  • Update voting contributor identification based on recent developer policy changes around email addresses.
  • Add additional language around this document being living, and explicitly require the project council to annually review feedback and evolve the process.
  • Include a timeline for initial adoption that includes testing voter identification scripting.

This updates the proposal with changes discussed during the review
manager meeting. The changes are:

* Update references to code owners to reflect the new maintainer role.
* Clarify that the project council will serve as a catch all for issues
  not covered by an area team.
* Explicitly state that area teams must communicate a timeline for
  decision making.
* Update voting contributor identification based on recent developer
  policy changes around email addresses.
* Add additional language around this document being living, and
  explicitly require the project council to annually review feedback and
  evolve the process.
* Include a timeline for initial adoption that includes testing voter
  identification scripting.
Copy link
Contributor

@dwblaikie dwblaikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(again, approving as incremental improvement of this draft, not as approval of the proposal)

Improvements look good to me - though please wait for at least one or two other approvals (@cyndyishida and @AaronBallman perhaps, though their suggestions so far seem small enough that they're easily validated without necessarily waiting on their individual confirmation specifically).

@llvm-beanz llvm-beanz changed the title Updates based on review manager meeting [LP0004] Updates based on review manager meeting Oct 17, 2024
Copy link

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


On adoption this proposal will be a living document. Changes to the process will be proposed through PRs and reviewed through the [Decision Making process](https://github.com/llvm/llvm-www/blob/main/proposals/LP0001-LLVMDecisionMaking.md). This proposal is not perfect, and should never be assumed to be static or fixed.

Each year, the _Project Council_ will collect feedback from _area teams_, _maintainers_, and the wider community on what is working, not working, or could be improved. That feedback will be discussed and this proposal will evolve to meet the needs of the community.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expand on "feedback will be discussed" to say something active, like "the project council will collect that feedback and present it at the developer meeting before each election cycle."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed dropping the mention of the developer meeting, which I think is fine. Just "shared ahead of the election cycle" seems good. We also used the words "transparency report" with possible operational changes.

proposals/LP0004-project-governance.md Show resolved Hide resolved
Copy link
Contributor

@echristo echristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A couple of inline comments.

Copy link
Member

@cyndyishida cyndyishida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants