Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP; adding mac support #54

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

WIP; adding mac support #54

wants to merge 6 commits into from

Conversation

dfl
Copy link

@dfl dfl commented Jun 3, 2024

I began work on adding Mac / MPS support.

bitsandbytes doesn't yet support MPS, but until then the alternative is MLX. I think this PR is close to working, however streaming is not supported by MLX so I haven't finished integration. Maybe someone else can help?

@fblissjr
Copy link

fblissjr commented Jun 7, 2024

so happy to see this, i had the exact same idea and wanted to check beforehand.

i wonder if we're better off just making it an openai spec for the llm. reason being that i'd probably run the SDXL model on a CUDA machine and the LLM on mlx.

@dfl
Copy link
Author

dfl commented Jun 7, 2024

@fblissjr hi! yes, that's the path I ended up going down but didn't complete... will push what I have

@dfl
Copy link
Author

dfl commented Jun 7, 2024

@fblissjr
Copy link

fblissjr commented Jun 7, 2024

@dfl
Copy link
Author

dfl commented Jun 8, 2024

@fblissjr thanks! are you able to take a crack at finishing up the integration?

Additionally, I see you have a fork of mlx-outlines... seems like outlines could be a useful addition to the project, no? #84 (comment)

@fblissjr
Copy link

fblissjr commented Jun 9, 2024

@fblissjr thanks! are you able to take a crack at finishing up the integration?

Additionally, I see you have a fork of mlx-outlines... seems like outlines could be a useful addition to the project, no? #84 (comment)

I didn't - got bogged down and now going to be out of pocket for a week. Most likely won't get to it unfortunately.

I did start outlines, forked from another fork. It was sorta working, but the project was just moving too fast and the fork too big of a drift that I abandoned it. Mostly was curious how far off it was from 'working' - which I discovered is still too far.

I think we need a proper mlx implementation of a constrained decoder & DSL rather than a retrofit of an older one.

@fblissjr
Copy link

@fblissjr thanks! are you able to take a crack at finishing up the integration?

Additionally, I see you have a fork of mlx-outlines... seems like outlines could be a useful addition to the project, no? #84 (comment)

@fblissjr thanks! are you able to take a crack at finishing up the integration?

Additionally, I see you have a fork of mlx-outlines... seems like outlines could be a useful addition to the project, no? #84 (comment)

@dfl just fyi, mlx adding logprobs, which will make stuff like outlines much easier to integrate: ml-explore/mlx-examples#826 (reply in thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants