-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
django object level permissions support #253
base: develop
Are you sure you want to change the base?
django object level permissions support #253
Conversation
2 similar comments
1 similar comment
@dirkmoors I will like to merge this. I will do it for next release if possible. I will rename migration since the 0003 is already in use. thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Would it be reasonable to add test with integrated Guardian support to avoid this being refactored away?
Needs to be rebased.
@@ -6,3 +6,4 @@ | |||
/dist/ | |||
/django_scheduler.egg-info/ | |||
/docs/_build/ | |||
.idea/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this line? It looks unrelated to the PR of adding object level permissions.
This PR will add support for the object level permission "view_".
This is very useful when integrating this library in a project that uses e.g. Django Guardian to handle the permissions: https://django-guardian.readthedocs.io/en/stable/userguide/assign.html#prepare-permissions