fix(deps): update dependencies

- jest: add `prefer-each` rule - jest: remove `no-jest-import` rule - jest: fix `unbound-method` condition for ts
ljosberinn · Sep 6, 2022 · 13c2a3f · 13c2a3f
1 parent 90b7add
commit 13c2a3f
Show file tree

Hide file tree

Showing 44 changed files with 49,370 additions and 49,001 deletions.
diff --git a/README.md b/README.md
@@ -21,14 +21,14 @@ npm install --save-dev eslint-config-galex eslint
 
 ~~As of January 2021 / due to CRA v5, currently no additional steps are required! 🎉~~
 
-Beginning with `eslint-config-galex` `v3.6.5` or newer, until this disclaimer is removed you need to install the following dependencies additionally:
+Beginning with `eslint-config-galex` `v4.2.2` or newer, until this disclaimer is removed you need to install the following dependencies additionally:
 
-- `"eslint-plugin-jest": "26.1.3"`
+- `"eslint-plugin-jest": "27.0.1"`
 
 ```sh
-npm i --save-dev eslint-plugin-jest@26.1.3
+npm i --save-dev eslint-plugin-jest@27.0.1
 
-yarn add -D eslint-plugin-jest@26.1.3
+yarn add -D eslint-plugin-jest@27.0.1
 ```
 
 </details>

diff --git a/__tests__/integration.test.ts b/__tests__/integration.test.ts
@@ -52,7 +52,10 @@ const normalizeSnapshot = (content: string) => {
               return word;
             }
 
-            return word.slice(word.indexOf(variablePathDelimiter));
+            // in codespaces, its /
+            const sanitized = word.split('/').join('\\');
+
+            return sanitized.slice(sanitized.indexOf(variablePathDelimiter));
           })
           .join(' ');
       })
@@ -63,12 +66,17 @@ const normalizeSnapshot = (content: string) => {
 const cases = [
   { name: 'create-react-app javascript', path: 'cra-js' },
   { name: 'create-react-app typescript', path: 'cra-ts' },
+
   { name: 'create-next-app javascript', path: 'next-js' },
   { name: 'create-next-app typescript', path: 'next-ts' },
+
   { name: 'create-remix javascript', path: 'remix-js' },
   { name: 'create-remix typescript', path: 'remix-ts' },
+
   { name: 'jest', path: 'jest' },
-  { name: 'nest typescript', path: 'next-ts' },
+
+  { name: 'nest typescript', path: 'nest-ts' },
+
   {
     name: 'js ts migration mix checkJs off',
     path: 'js-ts-migration-mix-checkJs-off',

diff --git a/__tests__/overrides/__snapshots__/jest.test.ts.snap b/__tests__/overrides/__snapshots__/jest.test.ts.snap
@@ -52,7 +52,6 @@ exports[`createJestRules default 1`] = `
   "jest/no-identical-title": "error",
   "jest/no-interpolation-in-snapshots": "error",
   "jest/no-jasmine-globals": "error",
-  "jest/no-jest-import": "error",
   "jest/no-large-snapshots": [
     "warn",
     {
@@ -68,6 +67,7 @@ exports[`createJestRules default 1`] = `
   "jest/no-try-expect": "off",
   "jest/prefer-called-with": "error",
   "jest/prefer-comparison-matcher": "warn",
+  "jest/prefer-each": "warn",
   "jest/prefer-expect-assertions": "off",
   "jest/prefer-expect-resolves": "warn",
   "jest/prefer-hooks-in-order": "warn",
@@ -133,7 +133,6 @@ exports[`createJestRules with create-react-app 1`] = `
     "jest/no-identical-title": "error",
     "jest/no-interpolation-in-snapshots": "error",
     "jest/no-jasmine-globals": "error",
-    "jest/no-jest-import": "error",
     "jest/no-large-snapshots": [
       "warn",
       {
@@ -149,6 +148,7 @@ exports[`createJestRules with create-react-app 1`] = `
     "jest/no-try-expect": "off",
     "jest/prefer-called-with": "error",
     "jest/prefer-comparison-matcher": "warn",
+    "jest/prefer-each": "warn",
     "jest/prefer-expect-assertions": "off",
     "jest/prefer-hooks-on-top": "error",
     "jest/prefer-inline-snapshots": "off",
@@ -160,7 +160,6 @@ exports[`createJestRules with create-react-app 1`] = `
     "jest/prefer-todo": "warn",
     "jest/require-to-throw-message": "off",
     "jest/require-top-level-describe": "off",
-    "jest/unbound-method": "warn",
     "jest/valid-expect": "error",
     "jest/valid-expect-in-promise": "error",
     "jest/valid-title": "warn",
@@ -229,7 +228,6 @@ exports[`createJestRules with typescript 1`] = `
     "jest/no-identical-title": "error",
     "jest/no-interpolation-in-snapshots": "error",
     "jest/no-jasmine-globals": "error",
-    "jest/no-jest-import": "error",
     "jest/no-large-snapshots": [
       "warn",
       {
@@ -245,6 +243,7 @@ exports[`createJestRules with typescript 1`] = `
     "jest/no-try-expect": "off",
     "jest/prefer-called-with": "error",
     "jest/prefer-comparison-matcher": "warn",
+    "jest/prefer-each": "warn",
     "jest/prefer-expect-assertions": "off",
     "jest/prefer-expect-resolves": "warn",
     "jest/prefer-hooks-in-order": "warn",
@@ -259,6 +258,7 @@ exports[`createJestRules with typescript 1`] = `
     "jest/prefer-todo": "warn",
     "jest/require-to-throw-message": "off",
     "jest/require-top-level-describe": "off",
+    "jest/unbound-method": "warn",
     "jest/valid-describe-callback": "error",
     "jest/valid-expect": "error",
     "jest/valid-expect-in-promise": "error",
@@ -280,7 +280,6 @@ exports[`createJestRules with typescript 1`] = `
 exports[`createTestOverrides with react 1`] = `
 {
   "import/no-namespace": "off",
-  "jest/unbound-method": "warn",
   "jsx-a11y/control-has-associated-label": "off",
   "no-empty-function": "off",
   "no-param-reassign": "off",
@@ -299,6 +298,7 @@ exports[`createTestOverrides with typescript 1`] = `
   "@typescript-eslint/no-unsafe-argument": "off",
   "@typescript-eslint/unbound-method": "off",
   "import/no-namespace": "off",
+  "jest/unbound-method": "warn",
   "no-empty-function": "off",
   "no-param-reassign": "off",
   "require-unicode-regexp": "off",
@@ -459,7 +459,6 @@ exports[`override snapshots with jest-dom 1`] = `
     "jest/no-identical-title": "error",
     "jest/no-interpolation-in-snapshots": "error",
     "jest/no-jasmine-globals": "error",
-    "jest/no-jest-import": "error",
     "jest/no-large-snapshots": [
       "warn",
       {
@@ -475,6 +474,7 @@ exports[`override snapshots with jest-dom 1`] = `
     "jest/no-try-expect": "off",
     "jest/prefer-called-with": "error",
     "jest/prefer-comparison-matcher": "warn",
+    "jest/prefer-each": "warn",
     "jest/prefer-expect-assertions": "off",
     "jest/prefer-expect-resolves": "warn",
     "jest/prefer-hooks-in-order": "warn",
@@ -489,7 +489,6 @@ exports[`override snapshots with jest-dom 1`] = `
     "jest/prefer-todo": "warn",
     "jest/require-to-throw-message": "off",
     "jest/require-top-level-describe": "off",
-    "jest/unbound-method": "warn",
     "jest/valid-describe-callback": "error",
     "jest/valid-expect": "error",
     "jest/valid-expect-in-promise": "error",
@@ -553,7 +552,6 @@ exports[`override snapshots with testing-lib 1`] = `
     "jest/no-identical-title": "error",
     "jest/no-interpolation-in-snapshots": "error",
     "jest/no-jasmine-globals": "error",
-    "jest/no-jest-import": "error",
     "jest/no-large-snapshots": [
       "warn",
       {
@@ -569,6 +567,7 @@ exports[`override snapshots with testing-lib 1`] = `
     "jest/no-try-expect": "off",
     "jest/prefer-called-with": "error",
     "jest/prefer-comparison-matcher": "warn",
+    "jest/prefer-each": "warn",
     "jest/prefer-expect-assertions": "off",
     "jest/prefer-expect-resolves": "warn",
     "jest/prefer-hooks-in-order": "warn",
@@ -583,7 +582,6 @@ exports[`override snapshots with testing-lib 1`] = `
     "jest/prefer-todo": "warn",
     "jest/require-to-throw-message": "off",
     "jest/require-top-level-describe": "off",
-    "jest/unbound-method": "warn",
     "jest/valid-describe-callback": "error",
     "jest/valid-expect": "error",
     "jest/valid-expect-in-promise": "error",

diff --git a/__tests__/overrides/__snapshots__/react.test.ts.snap b/__tests__/overrides/__snapshots__/react.test.ts.snap
@@ -3185,7 +3185,7 @@ exports[`override snapshots with remix 1`] = `
   "settings": {
     "import/ignore": [
       "node_modules",
-      "\\\\.(css|md|svg|json)$",
+      "\\.(css|md|svg|json)$",
     ],
     "import/resolver": {
       "jsconfig": {
@@ -3499,7 +3499,7 @@ exports[`override snapshots with remix and typescript 1`] = `
   "settings": {
     "import/ignore": [
       "node_modules",
-      "\\\\.(css|md|svg|json)$",
+      "\\.(css|md|svg|json)$",
     ],
     "import/parsers": {
       "@typescript-eslint/parser": [

diff --git a/__tests__/standalone.test.ts b/__tests__/standalone.test.ts
@@ -121,12 +121,9 @@ test('backupExistingEslintrc creates a scoped & formatted backup', () => {
   expect(Number.parseInt(parts[length - 2])).toBeLessThan(Date.now());
   expect(parts[length - 1]).toContain('bak.json');
 
-  expect(string).toMatchInlineSnapshot(`
-    "{
-      \\"foo\\": \\"bar\\"
-    }
-    "
-  `);
+  expect(JSON.parse(string)).toMatchObject({
+    foo: 'bar',
+  });
 });
 
 describe('generateStandalone', () => {

diff --git a/integration/cra-js/eslint-config.json b/integration/cra-js/eslint-config.json
@@ -1,7 +1,8 @@
 {
   "env": {
     "browser": true,
-    "node": true
+    "node": true,
+    "es6": true
   },
   "overrides": [
     {
@@ -266,7 +267,8 @@
         "plugin:jest-formatting/strict"
       ],
       "files": [
-        "**/*.?(test|spec).?(ts|js)?(x)"
+        "**/__tests__/**/*.[jt]s?(x)",
+        "**/?(*.)+(spec|test).[jt]s?(x)"
       ],
       "parserOptions": {
         "ecmaVersion": 2020
@@ -305,7 +307,6 @@
         "jest/no-identical-title": "error",
         "jest/no-interpolation-in-snapshots": "error",
         "jest/no-jasmine-globals": "error",
-        "jest/no-jest-import": "error",
         "jest/no-large-snapshots": [
           "warn",
           {
@@ -321,6 +322,7 @@
         "jest/no-try-expect": "off",
         "jest/prefer-called-with": "error",
         "jest/prefer-comparison-matcher": "warn",
+        "jest/prefer-each": "warn",
         "jest/prefer-expect-assertions": "off",
         "jest/prefer-hooks-on-top": "error",
         "jest/prefer-inline-snapshots": "off",
@@ -380,7 +382,6 @@
         "testing-library/prefer-user-event": "warn",
         "testing-library/prefer-wait-for": "warn",
         "testing-library/render-result-naming-convention": "off",
-        "jest/unbound-method": "warn",
         "import/no-namespace": "off",
         "no-empty-function": "off",
         "sonarjs/no-duplicate-string": "off",

diff --git a/integration/cra-js/package.json b/integration/cra-js/package.json
@@ -13,7 +13,7 @@
     "web-vitals": "^2.1.0"
   },
   "devDependencies": {
-    "eslint-plugin-jest": "26.1.3"
+    "eslint-plugin-jest": "27.0.1"
   },
   "scripts": {
     "start": "react-scripts start",

diff --git a/integration/cra-js/results.txt b/integration/cra-js/results.txt
@@ -1,4 +1,4 @@
-ESLint v8.21.0
+ESLint v8.23.0
 writing deps to eslint-config-galex\integration\cra-js\deps.json
 writing config cache to eslint-config-galex\integration\cra-js\eslint-config.json
 TAP version 13