-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data stream support #361
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 2918189 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add docstrings to all of the exported classes? There's also at least one error handling TODO left in here still.
Looks good and thank you for including an example!
added some, the annoying thing however is that docstrings don't show up on class instances. And we're only returning class instances to users, so they won't really profit from them.
errors are currently being logged to console, the TODO is in there for later improvements around re-requesting missing chunks or similar repair mechanisms. Deleted the TODOs |
|
||
const sendFile = async (room: Room, recipient: RemoteParticipant) => { | ||
console.log('sending file'); | ||
await room.localParticipant?.sendFile('./assets/maybemexico.png', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file doesn't exist, but when i added one and ran the example i got a rust panic
sending file
thread '<unnamed>' panicked at src/nodejs.rs:55:13:
failed to handle request: invalid request: message is empty
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fatal runtime error: failed to initiate panic, error 5
depends on livekit/rust-sdks#533
writing stream:
thoughts about writing: for STT we need a way to optionally also override the chunk index with this API
reading stream: