Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Azure OpenAI Realtime #97

Merged
merged 13 commits into from
Oct 14, 2024
Merged

Support for Azure OpenAI Realtime #97

merged 13 commits into from
Oct 14, 2024
+150 −21

Conversation

davidzhao
Copy link
Member

Ported from Python PR: livekit/agents#848

@davidzhao davidzhao requested review from bcherry and nbsp October 5, 2024 19:46
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 31d5e16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@livekit/agents-plugin-openai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

nbsp
nbsp requested changes Oct 5, 2024
View reviewed changes
Copy link
Member

@nbsp nbsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick pass, will properly test tomorrow

plugins/openai/src/realtime/api_proto.ts Outdated Show resolved Hide resolved
plugins/openai/src/realtime/realtime_model.ts Outdated Show resolved Hide resolved
plugins/openai/src/realtime/realtime_model.ts Outdated Show resolved Hide resolved
plugins/openai/src/realtime/realtime_model.ts Outdated Show resolved Hide resolved
bcherry
bcherry approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@bcherry bcherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and made some updates, detailed below

plugins/openai/src/realtime/realtime_model.ts Show resolved Hide resolved
plugins/openai/src/realtime/realtime_model.ts Show resolved Hide resolved
examples/src/minimal_assistant.ts Show resolved Hide resolved
nbsp
nbsp approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@nbsp nbsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg. this would technically be a minor change, so if you don't mind plugin-openai version being misaligned with agents that's the better way to do it. but also it's a small enough change i don't think it really matters too much

@davidzhao davidzhao merged commit 6fe2679 into main Oct 14, 2024
4 checks passed
@davidzhao davidzhao deleted the azure-support branch October 14, 2024 15:15
@github-actions github-actions bot mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcherry bcherry bcherry approved these changes

@nbsp nbsp nbsp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidzhao @bcherry @nbsp