Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature idea: detect git short version hash during build and embed into binary #340

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

syke99
Copy link
Contributor

@syke99 syke99 commented Dec 14, 2022

This PR addresses the first proposed solution to this issue. The second proposed solution is not implemented in this PR, but can be added with further information provided.

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2022

CLA assistant check
All committers have signed the CLA.

@matthewmueller
Copy link
Contributor

Hey @syke99 thanks for working on this!

I'm a bit confused by the PR though. It's not really connected to Bud in anyway. You'd need to add the -ldflags to the app command. Is this still a draft PR?

I'm also thinking we can simplify this buildinfo package quite a bit, pretty sure something like:

var Bud = "latest"
would suffice.

@syke99
Copy link
Contributor Author

syke99 commented Dec 21, 2022

Hey @matthewmueller, I'm so sorry. Yes, this was supposed to just be a draft PR for now. I was expecting to continue being able to work on it, but I've had some personal stuff come up that has been taking precedence, so I've had to step away. And you're right, that does seem like it would suffice for what I had added. Again, my apologies!!

@syke99 syke99 marked this pull request as draft December 21, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants