Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Strict Decimal Formatting Based on Provided Input Parameter #109

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

philliphartin
Copy link
Member

@philliphartin philliphartin commented Jul 15, 2024

Please do not merge. I have additional changes incoming.

Copy link

cloudflare-workers-and-pages bot commented Jul 15, 2024

Deploying usemods-cf with  Cloudflare Pages  Cloudflare Pages

Latest commit: 91d134b
Status: ✅  Deploy successful!
Preview URL: https://a3b2dc2e.usemods-cf.pages.dev
Branch Preview URL: https://feature-enforce-decimal-plac.usemods-cf.pages.dev

View logs

…l places

Multiplying the original fractional number by 100 can introduce rounding errors, causing the default decimal place code to count zeroes as decimal places.
This update ensures that only real decimal places (non-zero values) are counted.
@philliphartin philliphartin self-assigned this Jul 17, 2024
@philliphartin philliphartin marked this pull request as draft July 17, 2024 01:28
@philliphartin philliphartin changed the title Always apply decimal formatting value when provided as an input parameter Strictly format to the number of decimals when provided as an input parameter Jul 17, 2024
@philliphartin philliphartin changed the title Strictly format to the number of decimals when provided as an input parameter Implement Strict Decimal Formatting Based on Provided Input Parameter Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant