Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(litmus): add pod annotations support #274

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

itninja-hue
Copy link
Contributor

@itninja-hue itninja-hue commented Sep 14, 2022

What this PR does / why we need it:

add support for pod annotations

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@f4tal-err0r
Copy link

This is a great add, need this as well.

Copy link
Member

@Jasstkn Jasstkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itninja-hue itninja-hue force-pushed the litmus/add_pod_annotations_support branch from 2f300db to 66c3de8 Compare September 16, 2022 08:51
@Jasstkn
Copy link
Member

Jasstkn commented Sep 21, 2022

@imrajdas @ispeakc0de hey. could you review this MR?

@itninja-hue itninja-hue changed the title feat(litmus): add pod annotaion support feat(litmus): add pod annotation support Sep 22, 2022
@itninja-hue itninja-hue changed the title feat(litmus): add pod annotation support feat(litmus): add pod annotations support Sep 22, 2022
@Jonsy13
Copy link
Contributor

Jonsy13 commented Oct 4, 2022

Hi @itninja-hue Can you resolve the conflicts in this PR.

@@ -26,6 +26,12 @@ spec:
{{- if .Values.portal.server.customLabels }}
{{ toYaml .Values.portal.server.customLabels | nindent 8 }}
{{- end }}
{{- if .Values.portal.server.podAnnotations }}
annotations:
{{- range $key, $value := .Values.portal.server.podAnnotations }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itninja-hue Please consider replacing this with:

{{- with .Values.portal.server.podAnnotations }}
{{ toYaml . | indent 8 }}
    {{- end }}

This should result in the equivalent values yaml being:

[...]
portal:
  server:
    podAnnotations:
      annotation: "example"
      annotation.two: "example"
      [...]

instead of being divided into two keys and is much easier.

@Jonsy13
Copy link
Contributor

Jonsy13 commented Oct 10, 2022

Hi @itninja-hue Can you resolve the conflicts in this PR.

@uditgaurav
Copy link
Member

Hi @itninja-hue, Can you please update the branch.

@Calvinaud
Copy link
Contributor

@itninja-hue Is this PR still active ? I'm interested by this PR and can work on it if needed.

@Calvinaud Calvinaud mentioned this pull request Oct 16, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants