Added support for EXP35U538CW #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for your contribution. I did checked briefly your json and I discovered some potential issues. It seems, that you are using same command multiple times, this is not optimal. Please check this this docs to avoid command dupliation and simplify the file. |
|
I've removed any duplicates that aren't explicitly needed and trimmed a few other things as well. |
Removed even more unnecessary code.
Final removal of unutilized fan-modes, where the AC simply doesn't allow that specific fan-mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Electrolux EXP35U538CW, called it 1706 as a continuation of the existing electrolux .json!