chore(mypy): enable truthy-bool error code

[sobolevn]

Docs: https://mypy.readthedocs.io/en/stable/error_code_list2.html#check-that-expression-is-not-implicitly-true-in-boolean-context-truthy-bool

I am using # type: ignore[truthy-bool] for .components check, because I see that it is treated specially for some reason (like pragma: no cover). Is this correct?

I also removed configs that are part of the --strict flag from settings.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.44%. Comparing base (ed35b61) to head (f9b187d).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3824      +/-   ##
==========================================
+ Coverage   98.42%   98.44%   +0.01%     
==========================================
  Files         333      333              
  Lines       15348    15346       -2     
  Branches     1694     1693       -1     
==========================================
  Hits        15107    15107              
+ Misses        111      110       -1     
+ Partials      130      129       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sobolevn]

Please, take a look at these lines:

Looks like else is never actually reached. Should I remove this branch?

[provinzkraut]

Looks like else is never actually reached. Should I remove this branch?

Seems to be a missing test case?

[sobolevn]

Seems to be a missing test case?

I am not quite sure, to be honest :)
Here's why. Here's the code in question:

litestar/litestar/security/base.py

Lines 90 to 95 in f7b258f

	if isinstance(app_config.openapi_config.components, list):
	app_config.openapi_config.components.append(self.openapi_components)
	elif app_config.openapi_config.components:
	app_config.openapi_config.components = [self.openapi_components, app_config.openapi_config.components]
	else:
	app_config.openapi_config.components = [self.openapi_components]

Where app_config.openapi_config.components has a type of Components | list[Components]

litestar/litestar/openapi/config.py

Line 91 in f7b258f

components: Components | list[Components] = field(default_factory=Components)

Components can never be false (it does not have __bool__ or __len__ defined).

So, mypy raises an error for this case. We either have:

• Missing None annotation for components and a missing test case ?
• Extra else branch in this if ?

[provinzkraut]

* Extra `else` branch in this `if` ?

Isn't it the elif branch that's extra then, and should be an else instead?

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3824