Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set correct path_template value for trie node (#3806) #3807

Merged

Conversation

wallseat
Copy link
Contributor

Closes #3806

@wallseat wallseat requested review from a team as code owners October 15, 2024 17:57
@github-actions github-actions bot added area/private-api This PR involves changes to the privatized API size: small type/bug pr/external Triage Required 🏥 This requires triage labels Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (5255ec3) to head (8622140).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3807   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files         332      332           
  Lines       15499    15500    +1     
  Branches     1703     1703           
=======================================
+ Hits        15253    15254    +1     
  Misses        113      113           
  Partials      133      133           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wallseat
Copy link
Contributor Author

there is another pr about a similar problem
#3784

@provinzkraut
Copy link
Member

Can you add a test case that breaks with the incorrect behaviour and passes with the fix?

@wallseat wallseat force-pushed the fix/inavlid-path-template-value branch from b1a55e7 to c59d48e Compare October 21, 2024 19:17
@wallseat
Copy link
Contributor Author

@provinzkraut Sure!
should i do it as a prometheus test or aregular litestar test case?

@wallseat
Copy link
Contributor Author

@provinzkraut added as prometheus test case

Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3807

@provinzkraut provinzkraut merged commit 91ec7a3 into litestar-org:main Oct 22, 2024
25 checks passed
@wallseat wallseat deleted the fix/inavlid-path-template-value branch October 23, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/private-api This PR involves changes to the privatized API pr/external size: small Triage Required 🏥 This requires triage type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: request.scope["path_template"] different from request.scope["path"] and sometimes empty
2 participants