add serde for some matrix types #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganthomas
approved these changes
Sep 25, 2024
mratsim
pushed a commit
that referenced
this pull request
Oct 11, 2024
- conflicts with: - Plonky3#264 which added non-optional serde for Matrix so we drop the optional part of #5 - Plonky3#372 as such the PR is pretty much empty Co-authored-by: Mamy Ratsimbazafy <[email protected]> Co-authored-by: Will Song <[email protected]>
mratsim
added a commit
that referenced
this pull request
Oct 11, 2024
- conflicts with: - Plonky3#264 which added non-optional serde for Matrix so we drop the optional part of #5 - Plonky3#372 as such the PR is pretty much empty Co-authored-by: Mamy Ratsimbazafy <[email protected]> Co-authored-by: Will Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds serde support for some matrix types, which will assist in serializing valida proving and verifying keys