Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix std::as_const errors #27

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Fix std::as_const errors #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ include(ECMQmlModule)
## Disable use of C++ API deprecated in Qt 5.15
add_compile_definitions(QT_DISABLE_DEPRECATED_UP_TO=0x050F00)

## Enable -Werror by default:
add_compile_options(-Werror)

## Shared macros and functions:
if(NOT LIRI_LOCAL_ECM)
find_package(LiriCMakeShared "2.0.99" REQUIRED NO_MODULE)
Expand Down
2 changes: 1 addition & 1 deletion src/manager/session.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ void Session::shutdown()

// Stop modules
std::reverse(m_loadedModules.begin(), m_loadedModules.end());
for (auto module : qAsConst(m_loadedModules)) {
for (auto module : std::as_const(m_loadedModules)) {
auto instance = dynamic_cast<QObject *>(module);
const auto name = m_pluginRegistry->getNameForInstance(instance);

Expand Down
Loading