Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: redesign module tiles on project page and module detail page #5946

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

vellip
Copy link
Collaborator

@vellip vellip commented Jan 15, 2025

Describe your changes
adds new module tile, just the base style, grid and view all logic are coming in a later story. Also as per @MarleyMi request we leave the grey subtitle out for now due to skzl feedback.

CleanShot 2025-01-15 at 18 02 13

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@vellip vellip marked this pull request as draft January 20, 2025 13:42
@vellip vellip requested a review from hom3mad3 January 29, 2025 15:11
@vellip vellip marked this pull request as ready for review January 29, 2025 15:12
@vellip
Copy link
Collaborator Author

vellip commented Jan 29, 2025

@hom3mad3 ready for review, will rebase later

Copy link
Contributor

@hom3mad3 hom3mad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks! ✨

@vellip vellip force-pushed the pv-2025-01-module-tiles branch from c629515 to a24eb6d Compare January 29, 2025 16:46
@vellip vellip enabled auto-merge (rebase) January 29, 2025 16:46
@vellip vellip merged commit 03bbe43 into dev Jan 29, 2025
2 checks passed
@vellip vellip deleted the pv-2025-01-module-tiles branch January 29, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants