-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8651] kiezradar: add radius based model, serializer, api, view, template #5932
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. I left some comments regarding some things. And maybe we want a test for the radius limits (e.g. users can't create a radius < 500 or > 3000 ?. The PR needs a rebase as there are conflicts
from .serializers import SearchProfileSerializer | ||
|
||
|
||
class KiezRadarViewSet(viewsets.ModelViewSet): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@goapunk should we use here the a4 mixin for the permissions? maybe the same for the search profile view
517af1e
to
53b478f
Compare
53b478f
to
6865b7e
Compare
@goapunk I don't have time to add more tests. If you still request changes, could you please take over this PR to finish it as I will be away for 2 weeks and it is needed for @sevfurneaux to continue his work? |
Describe your changes
Add a kiezradar model with an optional one2one relation to search profile.
Still missing:
Tasks