[8664] auto searchprofile names

[goapunk]

Describe your changes
Add code to automatically name searchprofiles as Searchprofile 1, Searchprofile 2, etc.

Tasks

• PR name contains story or task reference
• Steps to recreate and test the changes
• Documentation (docs and inline)
• Tests (including n+1 and django_assert_num_queries where applicable)
• Changelog

[m4ra]

suggest to move the indexing in the save method.

[m4ra]

Left few comments, and I think we shouldn't let the name optional, but save it with the auto-generated function.

[m4ra]

update_fields is not a list, it needs a union IIRC. However, I would think number field shouldn't be part of updates, only saved upon creation.

[goapunk]

good catch, I'll remove it

[m4ra]

we also need an index on the number field.

[m4ra]

@goapunk looking at the story again, it asks that we always increase the index, even it existing profiles are deleted. But I cannot think of a simple way to do so, hence you may want to communicate this decision in the story for when the testing phase starts, they are aware.

[goapunk]

@goapunk looking at the story again, it asks that we always increase the index, even it existing profiles are deleted. But I cannot think of a simple way to do so, hence you may want to communicate this decision in the story for when the testing phase starts, they are aware.

will do, its already in the comments of the story as well

[sevfurneaux]

As Janek has confirmed we'll use this implementation for the naming, I'll wait for this PR to be merged and check all is working in my [#8661] Add 'Save Profile' button PR.

[m4ra]

thank you!