[#8527] emails: fix missing images, empty cta button and styling issues #5908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
goapunk
requested changes
Jan 2, 2025
meinberlin/config/settings/base.py
Outdated
| @@ -294,7 +294,9 @@ | |||
| LOGIN_URL = "account_login" | |||
| LOGIN_REDIRECT_URL = "/" | |||
|
|
|||
| EMAIL_BACKEND = "django.core.mail.backends.console.EmailBackend" | |||
| # EMAIL_BACKEND = "django.core.mail.backends.console.EmailBackend" | |||
There was a problem hiding this comment.
do we actually want to change this or did you accidentally add it to the commit ?
There was a problem hiding this comment.
Ah good catch, no it wasn't intented
vellip
force-pushed
the
pv-2024-12-mailing-fixes
branch
from
0b0815b to
4d6c3b4
Compare
goapunk
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
replace svg with png images as they are better supported, remove an unused cta block, and fix some styling. Also, a4 has been updated to use a new setting so projects can add their own attachments to emails, even those set in a4.
depends on liqd/adhocracy4#1741
closes #5878
Tasks