Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bplan: make some further adjustments to the bplan api to fix some iss… #5897

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Dec 18, 2024

Describe your changes
During the first testing I found some stuff we still needed to fix (convert point coordinates, add bplan_id field)

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@goapunk goapunk requested a review from m4ra December 18, 2024 14:31
@goapunk
Copy link
Contributor Author

goapunk commented Dec 18, 2024

@m4ra I will merge this already so the testing on dev can continue, please review it anyway.

@goapunk goapunk enabled auto-merge (rebase) December 18, 2024 14:32
@goapunk goapunk disabled auto-merge December 18, 2024 14:33
@goapunk goapunk force-pushed the jd-2024-12-bplan-api-point-id branch from ef18340 to 052ea65 Compare December 18, 2024 14:37
@goapunk goapunk merged commit 59ced74 into main Dec 18, 2024
2 of 3 checks passed
@goapunk goapunk deleted the jd-2024-12-bplan-api-point-id branch December 18, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant