Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry pick main to dev part 3 #5886

Merged
merged 21 commits into from
Jan 23, 2025
Merged

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Dec 12, 2024

Describe your changes
Briefly explain what you did and provide context for a clearer understanding.

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

Copy link
Contributor

@m4ra m4ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python picks OK!

Copy link
Collaborator

@vellip vellip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goapunk goapunk force-pushed the jd-2024-12-cherry-pick-main-part-2 branch from 4247b68 to 8d4c6b7 Compare January 7, 2025 08:39
@goapunk goapunk force-pushed the jd-2024-12-cherry-pick-main-part-3 branch from 5609ddb to 8736f50 Compare January 7, 2025 08:40
@goapunk goapunk changed the base branch from jd-2024-12-cherry-pick-main-part-2 to dev January 7, 2025 13:29
@goapunk goapunk force-pushed the jd-2024-12-cherry-pick-main-part-3 branch 3 times, most recently from 6e4827b to a1ca8e3 Compare January 9, 2025 09:55
@goapunk
Copy link
Contributor Author

goapunk commented Jan 9, 2025

I've added a new commit to the end which modifies the plan serializer, this way the ci passes

@goapunk goapunk force-pushed the jd-2024-12-cherry-pick-main-part-3 branch from a1ca8e3 to 9fc182f Compare January 22, 2025 16:25
goapunk and others added 20 commits January 23, 2025 11:06
get the bplan objects.

This would cause any new migration which added a new field to the
model to fail.
string containing (geo)json, not actual json
- add missing <i> tag to allow italic in Bleach config
- add missing css for text sizing via ckeditor

fixes #5925
also fixes bug tile_image used instead of image_url
@goapunk goapunk force-pushed the jd-2024-12-cherry-pick-main-part-3 branch from 9fc182f to 79792e4 Compare January 23, 2025 10:09
@goapunk goapunk changed the title WIP: cherry pick main to dev part 3 cherry pick main to dev part 3 Jan 23, 2025
@goapunk goapunk merged commit 5a5fe85 into dev Jan 23, 2025
3 checks passed
@goapunk goapunk deleted the jd-2024-12-cherry-pick-main-part-3 branch January 23, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants