-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cherry-pick first batch of changes from main #5884
base: dev
Are you sure you want to change the base?
Conversation
- refactor ParagraphForm.jsx to new django-ckeditor-5 api - update django-ckeditor-5 - add setting to limit file uploads to 5mb
- extend logic from projects to external projects and plans - add signal to reset cache when new phases are created - add and update tests for some more cases - improve queries with some selecte_related / prefetch_related - use delay_on_commit for tasks called via signals to prevent race condition - update celery to 5.4.0
- add module publish and unpublish signals to refresh the cache - add project_component_updated signal to refresh the cache fixes #5684
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python picks LGTM!
I'd rather let @hom3mad3 have a look at the FE parts, as I haven't worked on these. Regarding
I think it doesn't matter too much to have that in because the style changed for |
Thanks, I'll take it out then! |
- remove old Django lts version and add new one - remove old wagtail lts versions
c9adb43
to
c893184
Compare
I'll go ahead and merge this so we can update a4 again. @hom3mad3 if you have any remarks I can fix them later! |
@m4ra hmm, now the tests are failing but locally it works both on sqlite3 and postgresql, no idea what's wrong :/ |
Here same, tests pass both in sqlite3 and postgresql. I re-run the build. |
Same error. I don't remember why we have set 3 queries when requesting the plans. Do you? @goapunk |
not really, I think that was just the number when we first ran the test. The confusing thing is it works on main, so I don't really know what's different on dev which breaks it? I will try to have a closer look at the queries |
Describe your changes
I cherry-picked the changes from
main
we want to bring todev
, these are mostly manual changes, I will open a second PR for dependency updates.I'll just tag everyone involved here and maybe you can have a quick look at the list of commits of concern to you and say if any of them shouldn't be included here.
@vellip wasn't sure about select_dropdown.scss: remove confusing greyed out first select item but seemed reasonable to have that on dev as well?
Tasks