-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cogify): Update the cogify create cog to support topo raster. BM-1116 #3388
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Blayne Chard <[email protected]>
|
||
return { | ||
command: 'gdal_translate', | ||
output: targetTiff, | ||
args: [ | ||
['-of', 'COG'], | ||
cfg.srcwin ? ['-srcwin', cfg.srcwin[0], cfg.srcwin[1], cfg.srcwin[2], cfg.srcwin[3]] : undefined, | ||
cfg.bigTIFF ? ['-co', `BIGTIFF=${cfg.bigTIFF}`] : ['-co', 'BIGTIFF=IF_NEEDED'], // BigTiff is somewhat slower and most (All?) of the COGS should be well below 4GB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need bigtiffs? everything should be well below 4gb?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We set big tiff as no
in the topo-raster
, and If_needed
for all others atm.
@@ -142,3 +146,45 @@ export function gdalCreate(targetTiff: URL, color: Rgba, opt: CogifyCreationOpti | |||
.map(String), | |||
}; | |||
} | |||
|
|||
export function gdalBuildTopoRasterCommands( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export function gdalBuildTopoRasterCommands( | |
export function gdalBuildTopoCog( |
To mirror the naming convention used here.
Motivation
Update the cogify create cog cli to support for both topo-raster cog and aerial raster cog creation together, so we can use the argo-task topo-stac-creation to prepare the stac files for topo raster map and reuse the create cog cli to do the cog creation.
Modifications
linz_basemaps:options
that allow to config into the dgal commands via these settings from stac files.tileId
to set as xyz Tile Id for aerial map or mapsheet Id for topo raster map.noReprojecting
to set in order to skip the reprojecting step ingdalwrapvrt
, as well as to set the target projection as the source indgaltranslate
linz:slug
if exists.Verification
Test imported topo raster previews:
Test workflow the topo raster standardised
Test basemaps import workflow with background.
Test on existing aerial map import feature that is not impacted.