Reverting change in d377c95 to fix letsencrypt symlink #531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting change made in commit d377c95 that stopped symlinking the certbot config directory to /etc/letsencrypt
Description:
There was a change in the commit
d377c95
that pointed Certbot to--config-dir
to/config/etc/letsencrypt
which combined with the removal of the symlink creation inroot/etc/s6-overlay/s6-rc.d/init-swag-folders/run
for/config/etc/letsencrypt
and/etc/letsencrypt
, caused the break.Additional changes to the Certbot in this commit included
root/etc/s6-overlay/s6-rc.d/init-certbot-config/run
which also now points multiple commands to/config/etc/letsencrypt
vs the previously existing/etc/letsencrypt
.This stopped Swag from being able to start up correctly as the letsencrypt service was unable to locate any certificates.
I may be incorrect in assuming this but keeping
/config/etc/letsencrypt
and adding back the symlink seemed like the best way forward.Benefits of this PR and context:
This is a break-fix - No github issue but a Discord one - https://discord.com/channels/354974912613449730/1325836298086518784
How Has This Been Tested?
To test my fix, I made the change in
root/etc/s6-overlay/s6-rc.d/init-certbot-config/run
to create the symlink, rebuilt the container and tested in a known previously working deployment. The server started with multiple subdomains functioning as expectedI built the container on a Macbook (arm) but built for and deployed on
linux/amd64
as the Docker server running Sweag in my infrastructure runs Unraid.Source / References: