Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting change in d377c95 to fix letsencrypt symlink #531

Closed
wants to merge 2 commits into from

Conversation

VisibleSampling
Copy link

@VisibleSampling VisibleSampling commented Jan 7, 2025

Reverting change made in commit d377c95 that stopped symlinking the certbot config directory to /etc/letsencrypt

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

There was a change in the commit d377c95 that pointed Certbot to --config-dir to /config/etc/letsencrypt which combined with the removal of the symlink creation in root/etc/s6-overlay/s6-rc.d/init-swag-folders/run for /config/etc/letsencrypt and /etc/letsencrypt, caused the break.

Additional changes to the Certbot in this commit included root/etc/s6-overlay/s6-rc.d/init-certbot-config/run which also now points multiple commands to /config/etc/letsencrypt vs the previously existing /etc/letsencrypt.

This stopped Swag from being able to start up correctly as the letsencrypt service was unable to locate any certificates.

I may be incorrect in assuming this but keeping /config/etc/letsencrypt and adding back the symlink seemed like the best way forward.

Benefits of this PR and context:

This is a break-fix - No github issue but a Discord one - https://discord.com/channels/354974912613449730/1325836298086518784

How Has This Been Tested?

To test my fix, I made the change in root/etc/s6-overlay/s6-rc.d/init-certbot-config/run to create the symlink, rebuilt the container and tested in a known previously working deployment. The server started with multiple subdomains functioning as expected

I built the container on a Macbook (arm) but built for and deployed on linux/amd64 as the Docker server running Sweag in my infrastructure runs Unraid.

Source / References:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-swag:3.0.1-pkg-f84aabc9-dev-fbb139ff27e7c30a8f468e0ca60b73475e3ba6f4-pr-531

@VisibleSampling
Copy link
Author

VisibleSampling commented Jan 7, 2025

I apologize, reading the guidelines it's suggested that I update a changelog however I don't see it anywhere. I'm fairly new to contributing to projects so I assume I've missed something basic somewhere. However, once I locate it, I will update it.

Edit: I found it... Was in a fairly obvious spot. Updated

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-swag:3.0.1-pkg-f84aabc9-dev-a166634796670e4e81822c0843b600453f16e073-pr-531

@VisibleSampling
Copy link
Author

Not needed. Spad in Discord was able to help me identify where the actual issue was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants