Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase to 3.21 #526

Merged
merged 7 commits into from
Jan 3, 2025
Merged

Rebase to 3.21 #526

merged 7 commits into from
Jan 3, 2025

Conversation

thespad
Copy link
Member

@thespad thespad commented Dec 17, 2024

linuxserver.io

  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Needs linuxserver/docker-baseimage-alpine-nginx#175 before merging but will work for testing without it.

The TL;DR is I've moved all the certbot paths to /config so there's nothing being written to the container any more.

f2b is an exception, no clue how easy it would be to make that work without writing to the container fs but don't know it well enough to properly engineer a solution.

Benefits of this PR and context:

How Has This Been Tested?

I've done some basic testing an clean issuance and renewal both seem to work but it needs a broad spread of testing to make sure we're not going to impact anyone (excluding people who've ChatGPT'd it and have fucked up volumes).

Source / References:

@thespad thespad requested a review from a team December 17, 2024 20:20
@thespad thespad self-assigned this Dec 17, 2024
@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-swag:3.0.1-pkg-dc9e7754-dev-2dc24f90c7b42e71babae2018bae67924edf86de-pr-526

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-swag:3.0.1-pkg-dc9e7754-dev-589b80e492940a1605084f895576a045b3d6d65f-pr-526

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-swag:3.0.1-pkg-dc9e7754-dev-c489e2c07fc15df695803240e845e1d9796ae035-pr-526

@thespad thespad marked this pull request as ready for review December 31, 2024 16:59
@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-swag:3.0.1-pkg-685237ed-dev-dbc5eb81fa0668abea937b7c554c01caf1cb9db2-pr-526

@LinuxServer-CI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

ghcr.io/linuxserver/lspipepr-swag:3.0.1-pkg-685237ed-dev-d3112c095355b85f2efd577be716973bb0923d73-pr-526

nemchik
nemchik approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@nemchik nemchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working. Upgraded existing container, forced renewal, and deleted certs so init would generate brand new.

@thespad thespad merged commit d376c95 into master Jan 3, 2025
6 checks passed
@thespad thespad deleted the 3.21 branch January 3, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemchik nemchik nemchik approved these changes

Assignees

@thespad thespad

Labels
None yet
Projects
Issue & PR Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thespad @LinuxServer-CI @nemchik