-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to iptables-legacy if iptables doesn't work #491
Conversation
…d doesn't work. Fixes linuxserver#476
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs the aarch64 Dockerfile updating as well
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
tested as functional by discord user: https://discord.com/channels/354974912613449730/1269985663881711627 leveraging the fallback to legacy. tested by me on a system not needing the fallback to legacy. it stayed on iptabled 1.8.10 nf_tables rather than legacy. no impact to functionality that I was able to see. |
Description:
Closes #476
On some systems 'iptables' gives an error. This implements the solution from https://github.com/crazy-max/docker-fail2ban ie. install iptables-legacy, and if iptables gives an error symlink iptables -> iptables-legacy.
This allows fail2ban to work. I was hitting this problem and this resolved it for me.
Benefits of this PR and context:
Fixes broken fail2ban on some systems.
How Has This Been Tested?
I ran with this fix with a Qnap host. I can docker exec -it swag /bin/sh and see banned ips with 'iptable -L -n' now - previously it would just give an error.
Source / References:
See issue #476 and the crazy-max fail2ban image.