Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements custom ACME servers #454

Closed
wants to merge 3 commits into from

Conversation

bokolob
Copy link

@bokolob bokolob commented Jan 31, 2024

Code mostly taken from: tashian@564e0d8

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

Code mostly taken from: tashian@564e0d8

Co-authored-by: Carl Tashian <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.8.0-pkg-b3147302-dev-2314a0359412da23f0f39504dbe4b7f2fcfa0a5a-pr-454/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.8.0-pkg-b3147302-dev-2314a0359412da23f0f39504dbe4b7f2fcfa0a5a-pr-454/shellcheck-result.xml

Tag Passed
amd64-2.8.0-pkg-b3147302-dev-2314a0359412da23f0f39504dbe4b7f2fcfa0a5a-pr-454
arm64v8-2.8.0-pkg-b3147302-dev-2314a0359412da23f0f39504dbe4b7f2fcfa0a5a-pr-454

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.8.0-pkg-b3147302-dev-58e1cf48a0519194729a1feb2206cb7f94e34dce-pr-454/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.8.0-pkg-b3147302-dev-58e1cf48a0519194729a1feb2206cb7f94e34dce-pr-454/shellcheck-result.xml

Tag Passed
amd64-2.8.0-pkg-b3147302-dev-58e1cf48a0519194729a1feb2206cb7f94e34dce-pr-454
arm64v8-2.8.0-pkg-b3147302-dev-58e1cf48a0519194729a1feb2206cb7f94e34dce-pr-454

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.9.0-pkg-c58afe06-dev-3f7f0924a6b6fea108efb18687a285dfc1203e74-pr-454/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.9.0-pkg-c58afe06-dev-3f7f0924a6b6fea108efb18687a285dfc1203e74-pr-454/shellcheck-result.xml

Tag Passed
amd64-2.9.0-pkg-c58afe06-dev-3f7f0924a6b6fea108efb18687a285dfc1203e74-pr-454
arm64v8-2.9.0-pkg-c58afe06-dev-3f7f0924a6b6fea108efb18687a285dfc1203e74-pr-454

@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@andrewmzhang
Copy link

Any reason why we can't get this merged?

@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@FackelAB
Copy link

Please review this Pull-Request - this is a very important feature for internal servers (not accessible from the internet)!

@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@andrewmzhang
Copy link

Hi LinuxServer.io, can we get this PR merged?

@timiti29
Copy link

timiti29 commented Aug 5, 2024

I'm interested too :)

best regards,

@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@FackelAB
Copy link

FackelAB commented Oct 2, 2024

Please make this available soon!!!

@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@FackelAB
Copy link

FackelAB commented Dec 4, 2024

Hi LinuxServer.io, can you get this PR merged? Please!

@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@drizuid
Copy link
Member

drizuid commented Jan 10, 2025

im not even going to look at the code; just look at the OP, they didnt even checkmark the box indicating they read the guidelines, they provided no info, this is by far one of the most low effort PRs i've seen. If you want something even considered, fill out the template. Im actually shocked i didnt see this and subsequently close it a year ago.

@drizuid drizuid closed this Jan 10, 2025
@drizuid drizuid added the invalid This doesn't seem right label Jan 10, 2025
@linuxserver linuxserver locked as spam and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid This doesn't seem right no-pr-activity
Projects
Development

Successfully merging this pull request may close these issues.

6 participants