Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass image name into application as DOCKER_TAG #7

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Floppy
Copy link
Contributor

@Floppy Floppy commented Nov 26, 2024

The application now reports its docker image name in usage stats, using the DOCKER_TAG environment variable (manyfold3d/manyfold#3213); this PR sets that env var to the Jenkins IMAGE build variable to get the same data for linuxserver builds.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@Roxedus
Copy link
Member

Roxedus commented Nov 26, 2024

The Jenkins file is templated, and those changes will be overwritten

@Floppy
Copy link
Contributor Author

Floppy commented Nov 26, 2024

Ah. That won't work then. Bear with me. :)

@Floppy
Copy link
Contributor Author

Floppy commented Nov 26, 2024

Hm; is there any way with the templating to pass in extra build args?

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/manyfold/v0.90.0-pkg-29e25ef9-dev-e17af3de5ab0d1e8ee527163c8541e788696363d-pr-7/index.html
https://ci-tests.linuxserver.io/lspipepr/manyfold/v0.90.0-pkg-29e25ef9-dev-e17af3de5ab0d1e8ee527163c8541e788696363d-pr-7/shellcheck-result.xml

Tag Passed
amd64-v0.90.0-pkg-29e25ef9-dev-e17af3de5ab0d1e8ee527163c8541e788696363d-pr-7
arm64v8-v0.90.0-pkg-29e25ef9-dev-e17af3de5ab0d1e8ee527163c8541e788696363d-pr-7

@Roxedus
Copy link
Member

Roxedus commented Nov 26, 2024

Im not too sure if we can set this dynamically with Jenkins. Hardcoding it in the dockerfile is a option.

@thespad
Copy link
Member

thespad commented Nov 26, 2024

You could just do DOCKER_TAG=${VERSION} in the Dockerfile(s) and that would get you (for example) v0.90.1-ls37

Or if you want the full tag DOCKER_TAG=lscr.io/linuxserver/manyfold:${VERSION}

@Floppy
Copy link
Contributor Author

Floppy commented Nov 27, 2024

That's a really good point! I hadn't even thought of just hardcoding it, I've obviously been an engineer for too long 😅

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/manyfold/v0.90.1-pkg-daa6a950-dev-cb83f85aa9693413950cb82e0fe804e77d732cab-pr-7/index.html
https://ci-tests.linuxserver.io/lspipepr/manyfold/v0.90.1-pkg-daa6a950-dev-cb83f85aa9693413950cb82e0fe804e77d732cab-pr-7/shellcheck-result.xml

Tag Passed
amd64-v0.90.1-pkg-daa6a950-dev-cb83f85aa9693413950cb82e0fe804e77d732cab-pr-7
arm64v8-v0.90.1-pkg-daa6a950-dev-cb83f85aa9693413950cb82e0fe804e77d732cab-pr-7

@thespad thespad merged commit a169532 into linuxserver:main Dec 3, 2024
2 checks passed
@Floppy Floppy deleted the docker-tag-var branch December 3, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants