-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass image name into application as DOCKER_TAG #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
The Jenkins file is templated, and those changes will be overwritten |
Ah. That won't work then. Bear with me. :) |
Hm; is there any way with the templating to pass in extra build args? |
I am a bot, here are the test results for this PR:
|
Im not too sure if we can set this dynamically with Jenkins. Hardcoding it in the dockerfile is a option. |
You could just do Or if you want the full tag |
That's a really good point! I hadn't even thought of just hardcoding it, I've obviously been an engineer for too long 😅 |
e17af3d
to
c084e0f
Compare
c084e0f
to
4fde196
Compare
I am a bot, here are the test results for this PR:
|
The application now reports its docker image name in usage stats, using the
DOCKER_TAG
environment variable (manyfold3d/manyfold#3213); this PR sets that env var to the JenkinsIMAGE
build variable to get the same data for linuxserver builds.