Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep required Ruby version at 3.3.3 for now #4

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Keep required Ruby version at 3.3.3 for now #4

merged 2 commits into from
Sep 6, 2024

Conversation

thespad
Copy link
Member

@thespad thespad commented Sep 4, 2024

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Alpine repo is still on 3.3.3 and might stay there. Edge is also still 3.3.3 but might be the best option if upstream project continues to bump Ruby requirement.

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

@thespad thespad requested a review from a team September 4, 2024 15:40
@thespad thespad self-assigned this Sep 4, 2024
@Floppy
Copy link
Contributor

Floppy commented Sep 4, 2024

In general upstream will indeed keep bumping to latest Ruby as long as Alpine has the version, so yeah, if you need to stick on 3.3.3, this makes sense :)

@thespad
Copy link
Member Author

thespad commented Sep 4, 2024

In general upstream will indeed keep bumping to latest Ruby as long as Alpine has the version, so yeah, if you need to stick on 3.3.3, this makes sense :)

Has something changed in 0.77 WRT auth? I'm getting a 403 on http://localhost:3214/ with our CI tests

@Floppy
Copy link
Contributor

Floppy commented Sep 4, 2024

In general upstream will indeed keep bumping to latest Ruby as long as Alpine has the version, so yeah, if you need to stick on 3.3.3, this makes sense :)

Has something changed in 0.77 WRT auth? I'm getting a 403 on http://localhost:3214/ with our CI tests

Ah, yes, auth is no longer required for all pages, because it can now handle public content. I'd expect it to be more permissive though, not less...

@Floppy
Copy link
Contributor

Floppy commented Sep 4, 2024

Ah, looking at the build error, it looks like it's getting permission denied on new library setup when first run? I will check what it's doing, I think that might be my bug in single-user mode,

@thespad
Copy link
Member Author

thespad commented Sep 4, 2024

Ah, looking at the build error, it looks like it's getting permission denied on new library setup when first run? I will check what it's doing, I think that might be my bug in single-user mode,

Yeah, this is clean run, CI testing, passing it SECRET_KEY_BASE=placeholder & DATABASE_URL=sqlite3:/config/manyfold.sqlite3 with our CI redis mod installed locally.

@Floppy
Copy link
Contributor

Floppy commented Sep 4, 2024

Yep, this is my fault. Thanks for pointing it out!

Just released a patch version to fix it, v0.77.1: https://github.com/manyfold3d/manyfold/releases/tag/v0.77.1

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/manyfold/v0.77.1-pkg-a76e1b4c-dev-b5922f4df638395ca6559c3b13d5cc3695d62bdd-pr-4/index.html
https://ci-tests.linuxserver.io/lspipepr/manyfold/v0.77.1-pkg-a76e1b4c-dev-b5922f4df638395ca6559c3b13d5cc3695d62bdd-pr-4/shellcheck-result.xml

Tag Passed
amd64-v0.77.1-pkg-a76e1b4c-dev-b5922f4df638395ca6559c3b13d5cc3695d62bdd-pr-4
arm64v8-v0.77.1-pkg-a76e1b4c-dev-b5922f4df638395ca6559c3b13d5cc3695d62bdd-pr-4

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/manyfold/v0.77.3-pkg-a76e1b4c-dev-b5922f4df638395ca6559c3b13d5cc3695d62bdd-pr-4/index.html
https://ci-tests.linuxserver.io/lspipepr/manyfold/v0.77.3-pkg-a76e1b4c-dev-b5922f4df638395ca6559c3b13d5cc3695d62bdd-pr-4/shellcheck-result.xml

Tag Passed
amd64-v0.77.3-pkg-a76e1b4c-dev-b5922f4df638395ca6559c3b13d5cc3695d62bdd-pr-4
arm64v8-v0.77.3-pkg-a76e1b4c-dev-b5922f4df638395ca6559c3b13d5cc3695d62bdd-pr-4

@thespad thespad merged commit 6e0fd20 into main Sep 6, 2024
3 checks passed
@thespad thespad deleted the pin-ruby branch September 6, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants