-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Other dbs #42
Other dbs #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
I am a bot, here are the test results for this PR:
|
Can you please explicitly list the possible options in the env description:
And while we're at it we should probably update the default to |
I am a bot, here are the test results for this PR:
|
Description:
I allowed the variable
CMD_DB_DIALECT
to be used to setup theCMD_URL_DB
in the hedgedoc service definition.Benefits of this PR and context:
The only way to customize the DB connection without leaking the database information in a compose file is to set up the variables:
FILE__DB_HOST
,FILE__DB_NAME
,FILE__DB_PASS
,FILE__DB_USER
.This however does not allow to use other databases beside MySQL, so I added the option to use the variable
CMD_DB_DIALECT
which is the specified method according to the hedgedoc documentation.This defaults to mysql, so if the variable is not set-up, the container will work as of now.
How Has This Been Tested?
I have built my hedgedoc instance using this changes, these changes allowed me to connect to a postgres database without leaking info in the compose file.
Source / References:
https://docs.hedgedoc.org/configuration/