-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Better contrast #429
base: master
Are you sure you want to change the base?
Conversation
I kind of like it - the color change should be in the _colors.scss file, though, then compiled to update cinnamon-dark.css. |
@mtwebster Missed the request for review in my email. I think visually it looks ok except for the fact that darkening the panel and menus has made all the borders disappear. Now everything just seems to die against the background and that doesn't look good, imho. I'm not a fan of how the menu and panel just look like one big block in the screenshot above. I also think the dark color would go best if it matched the dark color of the dark Gtk theme window titlebars and header bars so everything goes together nicely. You are right though that this was done incorrectly. The sass needs to be updated, not the .css files. The first time a build is done all of these changes would be overwritten by the old ones. |
@JosephMcc |
I've the same opinion as @JosephMcc. |
I pretty sure all you'd have to do is set the bg_color in common.scss to match the titlebar/headerbar color from the dark Gtk theme. Everything else probably will follow along without having to do much else. |
@luisrguerra don't hesitate to join https://matrix.to/#/#linuxmint-artists:matrix.org. We're looking at artwork changes for Mint 22, it'd be good to have a chat about it. |
Cinnamon's dark theme has little contrast and is very gray (Linux Mint as a whole uses a lot of gray and I've already mentioned this here before), it should be a little darker. In this pull request I changed the black tones to something more like the black theme in Windows 10 and 11. Microsoft paid a lot of designers just to decide which tone of black and white to use, I think it's a good idea to copy and paste of the hex code color.
Current theme: