Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Better contrast #429

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

luisrguerra
Copy link

@luisrguerra luisrguerra commented Mar 17, 2023

Cinnamon's dark theme has little contrast and is very gray (Linux Mint as a whole uses a lot of gray and I've already mentioned this here before), it should be a little darker. In this pull request I changed the black tones to something more like the black theme in Windows 10 and 11. Microsoft paid a lot of designers just to decide which tone of black and white to use, I think it's a good idea to copy and paste of the hex code color.
vmplayer_H6AMHQvACF

Current theme:
vmplayer_m92xpfykbz

@mtwebster
Copy link
Member

I kind of like it - the color change should be in the _colors.scss file, though, then compiled to update cinnamon-dark.css.

@mtwebster mtwebster added the Blocked Needs rebase, changes, or discussion label Mar 30, 2023
@JosephMcc
Copy link
Contributor

@mtwebster Missed the request for review in my email. I think visually it looks ok except for the fact that darkening the panel and menus has made all the borders disappear. Now everything just seems to die against the background and that doesn't look good, imho. I'm not a fan of how the menu and panel just look like one big block in the screenshot above. I also think the dark color would go best if it matched the dark color of the dark Gtk theme window titlebars and header bars so everything goes together nicely.

You are right though that this was done incorrectly. The sass needs to be updated, not the .css files. The first time a build is done all of these changes would be overwritten by the old ones.

@luisrguerra
Copy link
Author

@JosephMcc
In the future, I will try to revise the dark theme color palette in the code when I have time. However, I ask you to please start now to consider revising both the light (which is very gray) and dark themes for the upcoming versions of Linux Mint. The best approach would be to base the color palette on those used by systems such as MacOS, Windows, and ChromeOS. When developing these systems, companies hire multiple people to conduct detailed studies on the aesthetics, usability, and accessibility of the interface and the result is very good. In my opinion, interface developers of Linux desktop environments often tend to reinvent the wheel when it comes to the interface. Unfortunately, the results are usually disappointing and bring very few real innovations. In an analogy to an Olympic race, if the Linux world wants to become a leader in desktop operational systems, it needs to start running from the starting line, not from the back.

@clefebvre
Copy link
Member

I've the same opinion as @JosephMcc.

@clefebvre clefebvre changed the title Better contrast [WIP] Better contrast Jun 6, 2023
@JosephMcc
Copy link
Contributor

I pretty sure all you'd have to do is set the bg_color in common.scss to match the titlebar/headerbar color from the dark Gtk theme. Everything else probably will follow along without having to do much else.

@clefebvre
Copy link
Member

@luisrguerra don't hesitate to join https://matrix.to/#/#linuxmint-artists:matrix.org. We're looking at artwork changes for Mint 22, it'd be good to have a chat about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Needs rebase, changes, or discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants