Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add Cinnamon Menu Editor to Menu and System Settings by default #11977

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TranzistorP
Copy link

@TranzistorP TranzistorP commented Dec 10, 2023

Currently, the menu editor by default only opens with
'Right-click on the menu launch button - Edit menu.'

To figure out how to edit the Menu, I first spent about 20 minutes searching for this function in the Menu and System Settings. Then I googled it, but the search in Google in my language only suggested using third-party programs, and only the search in English gave a result.
I think it would be useful to add the menu editor by default to the Menu and possibly to the System Settings.
image
image

This is my first pull request and I would appreciate help and feedback.
I have a few questions:
What do I need to do to properly localize this item in the Menu?
Do I need to add it to generate_additional_files.py or somewhere else, or is the translation to .desktop done manually?
What do I need to do to properly localize this item in the System Settings?
Do I need to do the translation myself using Google Translate or are there separate people doing this?

Thank you for your attention and sorry for my English.

@TranzistorP TranzistorP changed the title [WIP] add Cinnamon Menu Editor to Menu by default [WIP] add Cinnamon Menu Editor to Menu and System Settings by default Dec 10, 2023
@fredcw
Copy link
Contributor

fredcw commented Dec 10, 2023

What's your use case for needing to edit the menu? I'm wondering if there may be some menu issues that might be better fixed elsewhere?

@TranzistorP
Copy link
Author

TranzistorP commented Dec 10, 2023

Сreating a shortcut is use case for needing to edit the menu .
Adding the ability to immediately select a menu category would fixed this issues.
image

@anaximeno
Copy link
Contributor

anaximeno commented Dec 10, 2023

@fredcw do you know if menu configurations work for the other (third parties) menus as well (Like Cinnamenu, and CinnVIIStarkMenu), i.e. is it a general configuration?

@TranzistorP
Copy link
Author

As I understand it, this is a general configuration because it is regulated directly in the .desktop files.
That is, this shortcut will be visible in any menu in the graphical shell with the name X-Cinnamon.

I checked, everything works in Cinnamenu.

@anaximeno
Copy link
Contributor

anaximeno commented Dec 12, 2023

Oh, ok. My question is in the sense if you remove one of the menu sections (like the "Others" section) in the menu editor, will that change reflect on other menus as well (can we garantee that)? Otherwise we would have a settings module that depends on the menu applet being used.

@fredcw
Copy link
Contributor

fredcw commented Dec 12, 2023

@anaximeno Yes, menu categories are in /usr/share/desktop-directories and apps are in /usr/share/applications and user defined versions of these, which override the systems ones are in ~/.local/share/desktop-directories and ~/.local/share/applications`

These files are read by cinnamon and all the menu applets query cinnamon appsystem for the menu structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants