-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Next] Add basic weather information to screensaver #464
base: master
Are you sure you want to change the base?
Conversation
Please squash the commits. |
Get basic temperature, conditions, location working with scaled icon Code cleanup Add IP Geolocation to weather component Cleanup, settings integrations, bugfixes, translation Fix Localization cleanup
all done. cleaned up some formatting too. Double-checked, seems ok from here (feedback welcome of course) |
Ok, first things first, this is pretty cool :) I don't want this to get into Cinnamon at the last minute. I think we should think about how weather is integrated as a whole into the desktop.. because this spans across an applet, a desklet, a screensaver.. which all deserve to be part of the Cinnamon core. In 6.4 we're also introducing Night Light.. and that (for the moment) reads our system timezone, but it also could potentially let the user define a position or calculate a position using geoip... and that's something which is quite global, as it can be useful here again for this weather-related set of features. Anyway, all this to say let's postpone this and give ourselves another 6 months to think about it. |
Yeah as I was working on this, it occurred to me that it would make sense to have centralized weather + location providers in Cinnamon to feed the desklet/applet/widget. Honestly the geolocation API already established in cinnamon-spices-applets/weather seems pretty robust and fleshed out, probably fairly easy to just incorporate that into the system. But this was a purely selfish PR, it's a feature I was fed up with living without lol so do with it what you will, I'll just keep running my personal builds until whenever. |
Weather Widget for cinnamon-screensaver
Adds a new type of floating widget (similar to Clock and AlbumArt) that displays a weather icon alongside the current weather conditions. Utilizes OpenWeatherMap for weather data and GeoJS.io for location data. Models and interfaces are designed to be mostly compatible with the Weather applet in cinnamon-spices-applets/weather@mockturtl so that additional Weather and Location providers can be easily added.
The OpenWeatherMap API key from the cinnamon-spices-applets has been reused to enable out-of-the-box operation.
Dependencies
App will crash until the dconf schema is updated.
PR with the new schema in cinnamon-desktop is here:
linuxmint/cinnamon-desktop#246
PR with updated cinnamon-settings screensaver module here:
linuxmint/cinnamon#12516
In the meantime:
/usr/share/glib-2.0/schemas/org.cinnamon.desktop.screensaver.gschema.xml
org.cinnamon.desktop.screensaver.gschema.xml.in
file to/usr/share/glib-2.0/schemas/org.cinnamon.desktop.screensaver.gschema.xml
(rename it to remove the.in
at the end)sudo glib-compile-schemas /usr/share/glib-2.0/schemas/
dconf-editor
or another means to set the relevant settings inorg.cinnamon.desktop.screensaver