Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file open bug & update readme #520

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

Cheny-chui
Copy link
Contributor

related issue:
#498

}
strcpy(connects_file_path, argv[0]);
strcpy(err_file_path, argv[0]);
strcpy(packets_file_path, argv[0]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里要判断一下,避免输入路径为空的时候成了绝对路径

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argv[0]应该永远是exe文件的绝对路径吧

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,这里这样处理一般情况下都没问题的,除非程序就在根目录

@helight
Copy link
Member

helight commented Sep 15, 2023

二进制文件不要提交到仓库哈

Copy link
Member

@helight helight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@helight helight merged commit 895a960 into linuxkerneltravel:develop Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants