-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
添加运行时参数,降低内核负载 #499
Merged
Merged
添加运行时参数,降低内核负载 #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abstract CONN_INIT and CONN_ADD_ADDRESS macro
abstract CONN_ADD_EXTRA_INFO CONN_INFO_TRANSFER PACKET_INIT_WITH_COMMON_INFO macro
Cheny-chui
requested review from
helight,
LinkinPF and
chenamy2017
as code owners
August 18, 2023 09:18
helight
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
helight
reviewed
Aug 18, 2023
sudo timeout -s SIGINT 20 ./tcpwatch || if [[ $? != 124 && $? != 0 ]];then exit $?;fi | ||
sudo timeout -s SIGINT 5 ./tcpwatch || if [[ $? != 124 && $? != 0 ]];then exit $?;fi | ||
sudo timeout -s SIGINT 5 ./tcpwatch -a || if [[ $? != 124 && $? != 0 ]];then exit $?;fi | ||
sudo timeout -s SIGINT 5 ./tcpwatch -e || if [[ $? != 124 && $? != 0 ]];then exit $?;fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些建议可以写到 makefile 中,这样这几 make test 或者 make runtest 来执行,这些代码其他人 git 下载下来也可以直接使用,这里写只能在 github 的流水线上使用。
LinkinPF
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Ref #498
Fixes # (issue)
Type of change
Please delete options that are not relevant.