Add pypi package #20
Closed
Add pypi package #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anders Roxell <[email protected]>
Its more pythonic to use __version__ than VERSION. Signed-off-by: Anders Roxell <[email protected]>
Make it easier to distribute kirk if it is a pip package. Can be built and installed with 'flit build', 'flit install --symlink' to install it locally. Signed-off-by: Anders Roxell <[email protected]>
|
@acerv Could you please have a look? LGTM. |
acerv
reviewed
Jul 8, 2024
| action="store_true", | ||
| help="Print current version") | ||
| action="version", | ||
| version=f"%(prog)s, {__version__}") |
There was a problem hiding this comment.
This is a good idea, we can integrate it in a separate patch.
There was a problem hiding this comment.
@roxell maybe just remove the last commit which adds pyproject.toml and force push? We could merge it already.
And for pypi, I'm not sure how much time it takes. If it's something long term, maybe add an issue for it? It would be followed by doc update pointing to pypi.
| @@ -0,0 +1,27 @@ | |||
| [build-system] | |||
There was a problem hiding this comment.
This method is not needed since we already use setuptools.
We don't really want to maintain two packaging systems.
|
This PR I rejected due to usage of setuptools and cf73030 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roxell Feel free to correct me.
@acerv @metan-ucw FYI Anders would appreciate have kirk published via pypi package, that's why this effort.
We have setuptools, but pypi package would allow to run 'pip install kirk' (that
would allow to avoid git dependency).
While I would not be against, sooner or later LTP users will need also ltx, thus pip
is not enough. But still having kirk available for any distro via pip will be useful for kselftests and io_uring.
Also, we could enable Debian package (and other distros) in OBS projects:
https://build.opensuse.org/package/show/benchmark:ltp:devel/ltx
https://build.opensuse.org/package/show/benchmark:ltp:devel/kirk