Wait for SSH command to complete after execution #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a documentation issue with the SSH module, where reset command is saved as `reset_command` but it's `reset_cmd`.
This parameter has been introduced long time ago and never removed after being replaced by --suite-timeout and --test-timeout parameters, which are using asyncio features instead.
This patch resolves a problem that started to show up when fast commands, such as 'cat', were executed on target. The original code was killing the command once we faced a return_value == None. This is obviously wrong and it probably comes from multiple SSH module implementations. The right thing to do is to wait for the process completion, once we finish to read stdout. In this way, return_value will be != None and we can process fast commands execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch resolves a problem that started to show up when fast commands, such as 'cat', were executed on target. The original code was killing the command once we faced a return_value == None. This is obviously wrong and it probably comes from multiple SSH module implementations.
The right thing to do is to wait for the process completion, once we finish to read stdout. In this way, return_value will be != None and we can process fast commands execution.