nvme: add NVMe 2.1 changed-alloc-ns-list-log command #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Just realized to add the alloc option into the existing the changed-ns-list-log command instead of to add the changed-alloc-ns-list-log command. |
igaw
reviewed
Jan 27, 2025
| { | ||
| if (alloc) | ||
| return nvme_get_log_changed_alloc_ns_list(dev->direct.fd, rae, len, ns_log); |
There was a problem hiding this comment.
I suppose the do_admin_op wrapper should be used here as well. Do we miss an API update in libnvme-mi?
There was a problem hiding this comment.
Yes sorry for the missing so will update libnvme-mi to add APIs later. Thank you.
igaw
reviewed
Jan 27, 2025
| k = NULL; | ||
|
|
||
| if (k) | ||
| obj_add_str(r, k, devname); |
There was a problem hiding this comment.
What about
if (asprintf(...) > 0)
obj_add_str(...)?
There was a problem hiding this comment.
Good so fixed as mentioned. Thank you.
The command functions combined with the changed-ns-list-log command. The output almost same but different as lists attached or allocated NSs. Signed-off-by: Tokunori Ikegami <[email protected]>
Added the nvme-changed-alloc-ns-list-log.txt file. Signed-off-by: Tokunori Ikegami <[email protected]>
Since missed to add the command into the command list. Signed-off-by: Tokunori Ikegami <[email protected]>
Both bash and zsh completions updated for the command. Signed-off-by: Tokunori Ikegami <[email protected]>
ikegami-t
force-pushed
the
alloc-ns-list
branch
from
6a8f3ef to
3ed2208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command functions combined with the changed-ns-list-log command. The output almost same but different as lists attached or allocated NSs.