PSL-Viz #278

tsalh · 2020-07-30T06:27:59Z

No description provided.

…might add code

…ruth table

…n class

…tractLogicalRule

…s methods, also got rid of comments in ContinuousEvaluator as we are using launcher now.

…o take a JSONObject and filename.

…ng individual satisfaction

…mpleAcquaintancestest that uses it, adjusted launcher to use the flag as well

… go into the newly designed data file

…a TODO for next steps

…_viz

… so that ground truth map, ground rule map, ground atom map, and rule map can all be arguments to the same method.

…inal push of new data file logic

…ill not be pushed until then. Changed the implementation for creating the new data file. Did some additional cleanup such as ordering imports, removing un-needed code, and style. Also added back parent rule weights to the data file instead of just booleans.

eriq-augustine

Nice, making good progress with the streaming JSON.

psl-cli/src/main/java/org/linqs/psl/cli/Launcher.java

psl-core/src/main/java/org/linqs/psl/application/inference/InferenceApplication.java

psl-core/src/main/java/org/linqs/psl/model/rule/arithmetic/AbstractArithmeticRule.java

psl-core/src/main/java/org/linqs/psl/util/VizDataCollection.java

…nts.

…there was a term that exactly matched it

…ed as doubles instead of ints as that more closely follows the inputed data

…paces written to JSON, included error message including the path for an IOException for path file, and some style changes.

eriq-augustine

Making some good progress.

Remember that I will typically only make a comment once, but it apples to all files.
(E.g. one letter variable names and missing spaces before braces.)

Aaron, can you review the comments that I have previously given Tarun.
There are a bunch apply, and we (you and I) have just not gone over yet.

psl-core/src/main/java/org/linqs/psl/util/ModelDataCollector.java

psl-core/src/main/java/org/linqs/psl/model/rule/arithmetic/AbstractArithmeticRule.java

psl-cli/src/main/java/org/linqs/psl/cli/Launcher.java

psl-core/src/main/java/org/linqs/psl/util/ModelDataCollector.java

…to avoid many access logs.

…anges, and renamed last few variables of visualization to model collection.

…_viz

…d flow changes

… codebase

AaronRodden and others added 30 commits April 1, 2020 11:34

First push to psl_viz development, marked a bunch of places where we …

20dcd08

…might add code

fixed merge conflicts, pom version stuff

050f0b3

Somewhat messy commit, but got a proof of concept for prediction vs t…

6c91eae

…ruth table

Pushing some changes from meeting

abc2823

Merge branch 'develop' into psl_viz

d9252c3

Got rid of some comments and things from my various testing

62ebe0f

Fixed some styling, cleaned some comments, organized VizDataCollectio…

c04d221

…n class

Found some new tests, got rid of a print out from past testing in Abs…

727322a

…tractLogicalRule

Beginning process of moving viz data collection calls to cli

3fc459b

Started setting up launcher to handle vizualization

ea9a16a

Got rid of using evaluator object and instead use code from one of it…

86e5e8e

…s methods, also got rid of comments in ContinuousEvaluator as we are using launcher now.

Finsished implementation of prediction vs truth data in cli

f295d01

Added a viz command line argument option

807b8c8

Changed the flag name and option name

983d21b

Passing ground rules over to VizDataCollection now

8a0a093

Finished proof of concept for ground rule satisfaction histogram

5c53b06

Groundings per Rule implemented.

0533607

Groundings per rule now implemented and modifed outputJSON() method t…

24a5ec7

…o take a JSONObject and filename.

Fixed JSON labeling and setup file output for total rule satisfaction.

4ea7771

Put all json data into one json, sectioned off via different keys

54a023f

Fixed the total sat module methods to add up totals instead of grabbi…

17a251f

…ng individual satisfaction

Added sat / dis split as well as percentages to json

2168317

Missed a debug print in last push

245c238

Grabbing violated ground rules and their consensus values

cbb29e6

Changed the data collection for violated ground rules

070a11d

Added the visualization flag to command line handler, also added a Si…

32398aa

…mpleAcquaintancestest that uses it, adjusted launcher to use the flag as well

Removed unparented number of ground rules from statistics.

c62c4fe

got rid of weight flag in violation data collection

1bbcb42

Did a sweep of the code for style, readability, variable names, etc.

071f3ad

Got needed data for a overall rule map, need to organize it now

caf2ae5

AaronRodden and others added 3 commits August 21, 2020 15:16

Added functionallity to create a Non-DNF ground rule, which will then…

1660ce7

… go into the newly designed data file

Got rid of an un-needed function, and prints from last commit. Added …

dca1584

…a TODO for next steps

Gathered all Arithmetic Rules. (temporary)

a874434

tsalh force-pushed the psl_viz branch from 731cd97 to a874434 Compare August 22, 2020 00:10

AaronRodden and others added 2 commits August 21, 2020 18:02

Merge branch 'psl_viz' of https://github.com/AaronRodden/psl into psl…

cfa8084

…_viz

Refactored write to output file while minimizing write buffer.

8e1ce89

tsalh force-pushed the psl_viz branch from ced65e9 to 8e1ce89 Compare August 23, 2020 08:32

Removed collection of arithmetic ground rules and refactored writeMap…

5c666b5

… so that ground truth map, ground rule map, ground atom map, and rule map can all be arguments to the same method.

tsalh force-pushed the psl_viz branch from 902936b to 5c666b5 Compare August 27, 2020 00:16

AaronRodden added 3 commits August 27, 2020 19:57

Completed final data file logic, and cleaned up / refactored

6d7db0b

Fixing merge conflict, waiting for Arithmetic rule collection to do f…

44760f3

…inal push of new data file logic

eriq-augustine requested changes Sep 10, 2020

View reviewed changes

AaronRodden and others added 5 commits September 11, 2020 10:44

Added back arithmetic data collection with bug fix. Edited some comme…

9cf42fe

…nts.

Fixed an issue where characters in predicates were being replaced if …

aeeff9f

…there was a term that exactly matched it

Changed the decorated ground atoms to have their constants represetnt…

a7a8210

…ed as doubles instead of ints as that more closely follows the inputed data

Renamed VizDataCollection class to ModelDataCollector, removed whites…

a19f5e5

…paces written to JSON, included error message including the path for an IOException for path file, and some style changes.

Fixed if-else styling.

3d2fdb1

eriq-augustine requested changes Sep 15, 2020

View reviewed changes

eriq-augustine and others added 9 commits September 15, 2020 08:56

Changed how the collection config option is checked during grounding …

3a54d39

…to avoid many access logs.

User must now specify a path for model data collection, some style ch…

88f9616

…anges, and renamed last few variables of visualization to model collection.

Writing a commit to note down next steps for PR

6296afb

Merge branch 'psl_viz' of https://github.com/AaronRodden/psl into psl…

319bb26

…_viz

Collected arithmetic rule at different choke point.

4255885

Commit to recieve a change to data collection

9f0758a

Merge branch 'psl_viz' of https://github.com/AaronRodden/psl into psl…

2fa0f92

…_viz

Addressed PR comments: parseAtom returns GroundAtom, various style an…

682b778

…d flow changes

Did a style pass, added some comments and double checked additions to…

5cbd94f

… codebase

This was referenced Aug 16, 2022

Fatal error because of using Log4J 1.X dependencies without adding them as direct dependency #334

Closed

Refactoring and merging PSL-VMI feature #335

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PSL-Viz #278

PSL-Viz #278

tsalh commented Jul 30, 2020

eriq-augustine left a comment

eriq-augustine left a comment

PSL-Viz #278

Are you sure you want to change the base?

PSL-Viz #278

Conversation

tsalh commented Jul 30, 2020

eriq-augustine left a comment

Choose a reason for hiding this comment

eriq-augustine left a comment

Choose a reason for hiding this comment