Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TPT-3319: Add support for Apply Linode Firewalls #492

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

TPT-3319: Add support for Apply Linode Firewalls #492

wants to merge 2 commits into from

Conversation

jcallahan-akamai
Copy link
Contributor

📝 Description

This adds support for the POST /linode/instances/:id/firewalls/apply endpoint.

https://techdocs.akamai.com/linode-api/reference/post-apply-firewalls

✔️ How to Test

Code example:

    client = LinodeClient(os.getenv("LINODE_TOKEN"))

    # linode_id = YOUR LINODE ID

    linode = Instance(client, linode_id)
    linode.apply_firewalls() # Returns True if successful

Integration test:

make TEST_CASE=test_linode_apply_firewall testint

Unit tests:

make testunit

@jcallahan-akamai jcallahan-akamai requested a review from a team as a code owner December 26, 2024 21:20
@jcallahan-akamai jcallahan-akamai requested review from jriddle-linode and ykim-akamai and removed request for a team December 26, 2024 21:20
lgarber-akamai
lgarber-akamai approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing on my end, nice work!

jriddle-linode
jriddle-linode approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM working locally!

ykim-akamai
ykim-akamai approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just pushed a commit to fix test image due to debain10 image being deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykim-akamai ykim-akamai ykim-akamai approved these changes

@lgarber-akamai lgarber-akamai lgarber-akamai approved these changes

@jriddle-linode jriddle-linode jriddle-linode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jcallahan-akamai @jriddle-linode @lgarber-akamai @ykim-akamai