Hardcode --authentication-skip-lookup=true to short-circuit ConfigMap auth #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xch4z
changed the title
0xch4z
force-pushed
the
fix-skip-configmap-auth
branch
from
c0cd9d2 to
da4d7ab
Compare
This change hardcodes some flags. Setting --authentication-skip-lookup=false short circuits configmap lookup for authentication (no longer needed), allowing for more fine-grained permissions. Also hardcodes --cloud-provider to "linode".
0xch4z
force-pushed
the
fix-skip-configmap-auth
branch
from
da4d7ab to
b515853
Compare
0xch4z
changed the title
|
Since we're setting a default on the |
sibucan
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #91
This change hardcodes some flags. Setting
--authentication-skip-lookup=trueshort circuits configmap lookup for authentication (no longer needed), allowing for more fine-grained permissions. Also hardcodes --cloud-provider to "linode".The manifest template has also been updated to use a restricted clusterrolebinding.