Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated default postgresql version #21

Merged
merged 7 commits into from
Jan 20, 2025
Merged

feat: updated default postgresql version #21

merged 7 commits into from
Jan 20, 2025

Conversation

Ani1357
Copy link
Contributor

@Ani1357 Ani1357 commented Dec 4, 2024

APL-282
This PR updates the default of the postgresql version used for a cnpg database.

@Ani1357 Ani1357 requested a review from CasLubbers December 5, 2024 12:40
@CasLubbers CasLubbers self-assigned this Dec 5, 2024
@Ani1357 Ani1357 requested a review from CasLubbers December 10, 2024 16:43
@merll
Copy link
Contributor

merll commented Dec 12, 2024

I think offering the image catalog in the charts is a good idea, but I think we should not make this restrictive on the platform versions.

I could imagine the following scenarios:

  • Users want to migrate their DB here. They can test a recovery here, but if they use basebackup + WAL instead of a dump, and their database is not version 17 yet, this will not work.
  • There might be products and libraries that are not compatible with, or at least do not officially support PG 17 yet.
  • There are dozens of drop-in replacements for the official PostgreSQL images, which are not forks but just a packaged PG+Extensions. They often play well with CNPG and I think we should not unnecessarily obstruct their use in the chart. One example is TimescaleDB.

Also users running a production DB could face pod restarts in case of a platform upgrade, something that is not necessary and possibly unexpected.

Adding imageCatalogName and imageCatalogKind (for example) with the defaults would accommodate this, because then teams can even maintain their own ImageCatalog.

Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to wait until new APL version is released

@Ani1357 Ani1357 dismissed j-zimnowoda’s stale review January 20, 2025 08:58

New APL version released.

@Ani1357 Ani1357 merged commit 5534863 into main Jan 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants